2018-07-23 11:40:53

by Corentin LABBE

Subject: [PATCH] memory: jz4780-nemc: build depend on OF

jz4780-nemc use of_ functions, so it needs to depend on OF

This fix the following build failure on x86
drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/memory/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index a642552..faa1a23 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -124,6 +124,7 @@ config JZ4780_NEMC
default y
depends on MACH_JZ4780 || COMPILE_TEST
depends on HAS_IOMEM
+ depends on OF
help
This driver is for the NAND/External Memory Controller (NEMC) in
the Ingenic JZ4780. This controller is used to handle external
--
2.7.4

2018-07-23 15:37:20

by Randy Dunlap

Subject: Re: [PATCH] memory: jz4780-nemc: build depend on OF

On 07/23/2018 04:38 AM, Corentin Labbe wrote:
> jz4780-nemc use of_ functions, so it needs to depend on OF
>
> This fix the following build failure on x86
> drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/memory/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index a642552..faa1a23 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -124,6 +124,7 @@ config JZ4780_NEMC
> default y
> depends on MACH_JZ4780 || COMPILE_TEST
> depends on HAS_IOMEM
> + depends on OF
> help
> This driver is for the NAND/External Memory Controller (NEMC) in
> the Ingenic JZ4780. This controller is used to handle external
>

Duplicate of https://lore.kernel.org/lkml/[email protected]/


--
~Randy