2018-07-24 06:25:58

by Wei Yongjun

Subject: [PATCH -next] regulator: bd9571mwv: Make symbol 'dev_attr_backup_mode' static

Fixes the following sparse warning:

drivers/regulator/bd9571mwv-regulator.c:220:1: warning:
symbol 'dev_attr_backup_mode' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/regulator/bd9571mwv-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
index c44613b..274c5ed 100644
--- a/drivers/regulator/bd9571mwv-regulator.c
+++ b/drivers/regulator/bd9571mwv-regulator.c
@@ -217,7 +217,7 @@ static ssize_t backup_mode_store(struct device *dev,
return count;
}

-DEVICE_ATTR_RW(backup_mode);
+static DEVICE_ATTR_RW(backup_mode);

static int bd9571mwv_suspend(struct device *dev)
{

2018-07-24 06:43:38

by Geert Uytterhoeven

Subject: Re: [PATCH -next] regulator: bd9571mwv: Make symbol 'dev_attr_backup_mode' static

On Tue, Jul 24, 2018 at 8:24 AM Wei Yongjun <[email protected]> wrote:
>
> Fixes the following sparse warning:
>
> drivers/regulator/bd9571mwv-regulator.c:220:1: warning:
> symbol 'dev_attr_backup_mode' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds