2018-10-04 03:11:47

by zhong jiang

Subject: [PATCHv2] misc: cxl: delete possible null pointer dereference

It is safe to dereference an object below a NULL test. For the sake
of debugging. Just delete the call of possible null pointer dereference.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/misc/cxl/guest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index 3bc0c15..472e8db 100644
--- a/drivers/misc/cxl/guest.c
+++ b/drivers/misc/cxl/guest.c
@@ -1018,7 +1018,7 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n

void cxl_guest_remove_afu(struct cxl_afu *afu)
{
- pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
+ pr_devel("in %s\n", __func__);

if (!afu)
return;
--
1.7.12.4

2018-10-04 04:39:20

by Greg Kroah-Hartman

Subject: Re: [PATCHv2] misc: cxl: delete possible null pointer dereference

On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote:
> It is safe to dereference an object below a NULL test. For the sake
> of debugging. Just delete the call of possible null pointer dereference.
>
> Signed-off-by: zhong jiang <[email protected]>
> ---
> drivers/misc/cxl/guest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..472e8db 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,7 +1018,7 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>
> void cxl_guest_remove_afu(struct cxl_afu *afu)
> {
> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> + pr_devel("in %s\n", __func__);

This call should just be deleted, it's not needed, ftrace can be used
instead.

thanks,

greg k-h

2018-10-04 04:59:04

by zhong jiang

Subject: Re: [PATCHv2] misc: cxl: delete possible null pointer dereference

On 2018/10/4 12:38, Greg KH wrote:
> On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote:
>> It is safe to dereference an object below a NULL test. For the sake
>> of debugging. Just delete the call of possible null pointer dereference.
>>
>> Signed-off-by: zhong jiang <[email protected]>
>> ---
>> drivers/misc/cxl/guest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
>> index 3bc0c15..472e8db 100644
>> --- a/drivers/misc/cxl/guest.c
>> +++ b/drivers/misc/cxl/guest.c
>> @@ -1018,7 +1018,7 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>>
>> void cxl_guest_remove_afu(struct cxl_afu *afu)
>> {
>> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
>> + pr_devel("in %s\n", __func__);
> This call should just be deleted, it's not needed, ftrace can be used
> instead.
Fine. Will do.

Sincerely,
zhong jiang
> thanks,
>
> greg k-h
>
> .
>