2018-10-23 06:02:55

by zhong jiang

Subject: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

'radiob_array_table' and 'radiob_arraylen' is not used after setting its value.
It is safe to remove the unused variable.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
index 5cf29f5..3f33278 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
@@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
int i;
bool rtstatus = true;
u32 *radioa_array_table;
- u32 *radiob_array_table;
- u16 radioa_arraylen, radiob_arraylen;
+ u16 radioa_arraylen;

radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
radioa_array_table = RTL8723E_RADIOA_1TARRAY;
- radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH;
- radiob_array_table = RTL8723E_RADIOB_1TARRAY;

rtstatus = true;

--
1.7.12.4

2018-10-23 08:05:59

by Ping-Ke Shih

Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

On Tue, 2018-10-23 at 13:47 +0800, zhong jiang wrote:
> 'radiob_array_table' and 'radiob_arraylen' is not used after setting its
> value.
> It is safe to remove the unused variable.
>
> Signed-off-by: zhong jiang <[email protected]>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> index 5cf29f5..3f33278 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct
> ieee80211_hw *hw,
>   int i;
>   bool rtstatus = true;
>   u32 *radioa_array_table;
> - u32 *radiob_array_table;
> - u16 radioa_arraylen, radiob_arraylen;
> + u16 radioa_arraylen;
>  
>   radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
>   radioa_array_table = RTL8723E_RADIOA_1TARRAY;
> - radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH;
> - radiob_array_table = RTL8723E_RADIOB_1TARRAY;
>  
>   rtstatus = true;
>  

I think 8723ae has only one antenna, so you can remove radio B array as well.

2018-10-23 08:25:30

by zhong jiang

Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

On 2018/10/23 16:05, Pkshih wrote:
> On Tue, 2018-10-23 at 13:47 +0800, zhong jiang wrote:
>> 'radiob_array_table' and 'radiob_arraylen' is not used after setting its
>> value.
>> It is safe to remove the unused variable.
>>
>> Signed-off-by: zhong jiang <[email protected]>
>> ---
>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> index 5cf29f5..3f33278 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct
>> ieee80211_hw *hw,
>> int i;
>> bool rtstatus = true;
>> u32 *radioa_array_table;
>> - u32 *radiob_array_table;
>> - u16 radioa_arraylen, radiob_arraylen;
>> + u16 radioa_arraylen;
>>
>> radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
>> radioa_array_table = RTL8723E_RADIOA_1TARRAY;
>> - radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH;
>> - radiob_array_table = RTL8723E_RADIOB_1TARRAY;
>>
>> rtstatus = true;
>>
> I think 8723ae has only one antenna, so you can remove radio B array as well.
>
Yep, Will do.

Thanks,
zhong jiang