by Henry Chen

[permalink] [raw]

Subject: Re: [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings

Hi Rob,

Sorry for late reply. I missed this mail before.

On Fri, 2019-01-11 at 10:09 -0600, Rob Herring wrote:
> On Wed, Jan 02, 2019 at 10:09:52PM +0800, Henry Chen wrote:
> > Document the binding for enabling DVFSRC on MediaTek SoC.
> >
> > Signed-off-by: Henry Chen <[email protected]>
> > ---
> > .../devicetree/bindings/soc/mediatek/dvfsrc.txt | 26 ++++++++++++++++++++++
> > include/dt-bindings/soc/mtk,dvfsrc.h | 18 +++++++++++++++
> > 2 files changed, 44 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > create mode 100644 include/dt-bindings/soc/mtk,dvfsrc.h
> >
> > diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > new file mode 100644
> > index 0000000..402c885
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > @@ -0,0 +1,26 @@
> > +MediaTek DVFSRC Driver
>
> Bindings are for h/w blocks, not drivers.
ok.
>
> > +The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a
> > +HW module which is used to collect all the requests from both software and
> > +hardware and turn into the decision of minimum operating voltage and minimum
> > +DRAM frequency to fulfill those requests.
>
> Seems like the OPP table should be a child of this instead of where you
> currently have it?
Do you means the opp table that I put on scpsys likes below?
I think this opp table is used for mapping the performance state of
power domain, so I put it on scpsys device tree document.

dvfsrc_opp_table: opp-table {
compatible = "operating-points-v2-level";

dvfsrc_vol_min: opp1 {
opp,level = <MT8183_DVFSRC_LEVEL_1>;
};

dvfsrc_freq_medium: opp2 {
opp,level = <MT8183_DVFSRC_LEVEL_2>;
};

dvfsrc_freq_max: opp3 {
opp,level = <MT8183_DVFSRC_LEVEL_3>;
};

dvfsrc_vol_max: opp4 {
opp,level = <MT8183_DVFSRC_LEVEL_4>;
};
};

>
> > +
> > +Required Properties:
> > +- compatible: Should be one of the following
> > + - "mediatek,mt8183-dvfsrc": For MT8183 SoC
> > +- reg: Address range of the DVFSRC unit
> > +- dram_type: Refer to <include/dt-bindings/soc/mtk,dvfsrc.h> for the
> > + different dram type support.
>
> This information should come from the DDR controller or memory nodes
> probably. And we already have some properties related to DDR type.
Sorry, I don't know that before, could you give some hint or example for
that?

>
> > +- clock-names: Must include the following entries:
> > + "dvfsrc": DVFSRC module clock
> > +- clocks: Must contain an entry for each entry in clock-names.
> > +
> > +Example:
> > +
> > + dvfsrc_top@10012000 {
>
> Drop the '_top'. (Don't use '_' in node and property names)..
ok
>
> > + compatible = "mediatek,mt8183-dvfsrc";
> > + reg = <0 0x10012000 0 0x1000>;
> > + clocks = <&infracfg CLK_INFRA_DVFSRC>;
> > + clock-names = "dvfsrc";
> > + dram_type = <MT8183_DVFSRC_OPP_LP4>;
> > + };
> > diff --git a/include/dt-bindings/soc/mtk,dvfsrc.h b/include/dt-bindings/soc/mtk,dvfsrc.h
> > new file mode 100644
> > index 0000000..60b3497
> > --- /dev/null
> > +++ b/include/dt-bindings/soc/mtk,dvfsrc.h
> > @@ -0,0 +1,18 @@
> > +/* SPDX-License-Identifier: GPL-2.0
> > + *
> > + * Copyright (c) 2018 MediaTek Inc.
> > + */
> > +
> > +#ifndef _DT_BINDINGS_POWER_MTK_DVFSRC_H
> > +#define _DT_BINDINGS_POWER_MTK_DVFSRC_H
> > +
> > +#define MT8183_DVFSRC_OPP_LP4 0
> > +#define MT8183_DVFSRC_OPP_LP4X 1
> > +#define MT8183_DVFSRC_OPP_LP3 2
> > +
> > +#define MT8183_DVFSRC_LEVEL_1 1
> > +#define MT8183_DVFSRC_LEVEL_2 2
> > +#define MT8183_DVFSRC_LEVEL_3 3
> > +#define MT8183_DVFSRC_LEVEL_4 4
> > +
> > +#endif /* _DT_BINDINGS_POWER_MTK_DVFSRC_H */
> > --
> > 1.9.1
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

2019-03-20 08:53:32

by Nicolas Boichat

[permalink] [raw]

Subject: Re: [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings

On Mon, Feb 18, 2019 at 12:55 PM Henry Chen <[email protected]> wrote:
>
> Hi Rob,
>
> Sorry for late reply. I missed this mail before.
>
> On Fri, 2019-01-11 at 10:09 -0600, Rob Herring wrote:
> > On Wed, Jan 02, 2019 at 10:09:52PM +0800, Henry Chen wrote:
> > > Document the binding for enabling DVFSRC on MediaTek SoC.
> > >
> > > Signed-off-by: Henry Chen <[email protected]>
> > > ---
> > > .../devicetree/bindings/soc/mediatek/dvfsrc.txt | 26 ++++++++++++++++++++++
> > > include/dt-bindings/soc/mtk,dvfsrc.h | 18 +++++++++++++++
> > > 2 files changed, 44 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > > create mode 100644 include/dt-bindings/soc/mtk,dvfsrc.h
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > > new file mode 100644
> > > index 0000000..402c885
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > > @@ -0,0 +1,26 @@
> > > +MediaTek DVFSRC Driver
> >
> > Bindings are for h/w blocks, not drivers.
> ok.
> >
> > > +The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a
> > > +HW module which is used to collect all the requests from both software and
> > > +hardware and turn into the decision of minimum operating voltage and minimum
> > > +DRAM frequency to fulfill those requests.
> >
> > Seems like the OPP table should be a child of this instead of where you
> > currently have it?
> Do you means the opp table that I put on scpsys likes below?
> I think this opp table is used for mapping the performance state of
> power domain, so I put it on scpsys device tree document.
>
> dvfsrc_opp_table: opp-table {
> compatible = "operating-points-v2-level";
>
> dvfsrc_vol_min: opp1 {
> opp,level = <MT8183_DVFSRC_LEVEL_1>;
> };
>
> dvfsrc_freq_medium: opp2 {
> opp,level = <MT8183_DVFSRC_LEVEL_2>;
> };
>
> dvfsrc_freq_max: opp3 {
> opp,level = <MT8183_DVFSRC_LEVEL_3>;
> };
>
> dvfsrc_vol_max: opp4 {
> opp,level = <MT8183_DVFSRC_LEVEL_4>;
> };
> };
>
> >
> > > +
> > > +Required Properties:
> > > +- compatible: Should be one of the following
> > > + - "mediatek,mt8183-dvfsrc": For MT8183 SoC
> > > +- reg: Address range of the DVFSRC unit
> > > +- dram_type: Refer to <include/dt-bindings/soc/mtk,dvfsrc.h> for the
> > > + different dram type support.
> >
> > This information should come from the DDR controller or memory nodes
> > probably. And we already have some properties related to DDR type.
> Sorry, I don't know that before, could you give some hint or example for
> that?

So, I'm really not sure either... One example I could find is
Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt, but it still
doesn't specify memory type (it just passes parameters to ATF). You
can also look at
Documentation/devicetree/bindings/memory-controllers/ti/emif.txt (but
that only supports lpddr2 nodes, I guess we could add more types?).

Some ideas:
1. DDR controller: Maybe you can probe at runtime, what memory type
is being used? After all the FW will have configured the memory
controller properly, so you could read back that information, somehow.
2. memory node: Either add a new lpddr3/4/4x node in device tree
(like TI's emif), or add something to the memory node?
memory@40000000 {
device_type = "memory";
reg = <0 0x40000000 0 0x80000000>;
};
I don't see a binding document for memory though, and no one ever
seems to add anything but basic size information.

> >
> > > +- clock-names: Must include the following entries:
> > > + "dvfsrc": DVFSRC module clock
> > > +- clocks: Must contain an entry for each entry in clock-names.
> > > +
> > > +Example:
> > > +
> > > + dvfsrc_top@10012000 {
> >
> > Drop the '_top'. (Don't use '_' in node and property names)..
> ok
> >
> > > + compatible = "mediatek,mt8183-dvfsrc";
> > > + reg = <0 0x10012000 0 0x1000>;
> > > + clocks = <&infracfg CLK_INFRA_DVFSRC>;
> > > + clock-names = "dvfsrc";
> > > + dram_type = <MT8183_DVFSRC_OPP_LP4>;
> > > + };
> > > diff --git a/include/dt-bindings/soc/mtk,dvfsrc.h b/include/dt-bindings/soc/mtk,dvfsrc.h
> > > new file mode 100644
> > > index 0000000..60b3497
> > > --- /dev/null
> > > +++ b/include/dt-bindings/soc/mtk,dvfsrc.h
> > > @@ -0,0 +1,18 @@
> > > +/* SPDX-License-Identifier: GPL-2.0
> > > + *
> > > + * Copyright (c) 2018 MediaTek Inc.
> > > + */
> > > +
> > > +#ifndef _DT_BINDINGS_POWER_MTK_DVFSRC_H
> > > +#define _DT_BINDINGS_POWER_MTK_DVFSRC_H
> > > +
> > > +#define MT8183_DVFSRC_OPP_LP4 0
> > > +#define MT8183_DVFSRC_OPP_LP4X 1
> > > +#define MT8183_DVFSRC_OPP_LP3 2
> > > +
> > > +#define MT8183_DVFSRC_LEVEL_1 1
> > > +#define MT8183_DVFSRC_LEVEL_2 2
> > > +#define MT8183_DVFSRC_LEVEL_3 3
> > > +#define MT8183_DVFSRC_LEVEL_4 4
> > > +
> > > +#endif /* _DT_BINDINGS_POWER_MTK_DVFSRC_H */
> > > --
> > > 1.9.1
> > >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
>