2019-01-04 05:37:14

by Peng Hao

Subject: [PATCH] security/selinux/hooks: remove unneeded semicolon

Remove unneeded semicolon.

Signed-off-by: Peng Hao <[email protected]>
---
security/selinux/hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index a67459e..73c679e 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -1263,7 +1263,7 @@ static void selinux_write_opts(struct seq_file *m,
default:
BUG();
return;
- };
+ }
/* we need a comma before each option */
seq_putc(m, ',');
seq_puts(m, prefix);
--
1.8.3.1

2019-01-10 00:56:01

by Paul Moore

Subject: Re: [PATCH] security/selinux/hooks: remove unneeded semicolon

On Thu, Jan 3, 2019 at 7:55 PM Peng Hao <[email protected]> wrote:
>
> Remove unneeded semicolon.
>
> Signed-off-by: Peng Hao <[email protected]>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index a67459e..73c679e 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -1263,7 +1263,7 @@ static void selinux_write_opts(struct seq_file *m,
> default:
> BUG();
> return;
> - };
> + }
> /* we need a comma before each option */
> seq_putc(m, ',');
> seq_puts(m, prefix);

Thank you for your patch, but the selinux_write_opts() function was
just removed in v5.0-rc1 in commit e3489f8974e1 ("selinux: kill
selinux_sb_get_mnt_opts()").

--
paul moore
http://www.paul-moore.com