2019-01-17 00:02:55

by Fabrizio Castro

[permalink] [raw]
Subject: [PATCH 00/11] Add basic EK874 support

Dear All,

The EK874 is an evaluation kit for the RZ/G2E SoC (a.k.a. r8a774c0)
from Silicon Linux Corporation. It is made of two boards: cat874
(the main board) and cat875 (the sub board).

This series adds the device trees to describe the HW configuration
of the EK874, with some basic support.

This applies onto next-20190116

Thanks,
Fab

Biju Das (6):
dt-bindings: Add vendor prefix for Silicon Linux.
arm64: dts: renesas: Add Si-Linux CAT874 board support
arm64: dts: renesas: Add Si-Linux EK874 board support
arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2
arm64: dts: renesas: r8a774c0-cat874: Add uSD support
arm64: dts: renesas: cat875: Add ethernet support

Fabrizio Castro (5):
dt-bindings: arm: renesas: Add si-linux cat87[45] boards
clk: renesas: r8a774c0: Add missing CANFD clock
dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks
arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes
dt-bindings: can: rcar_canfd: document r8a774c0 support

Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++
.../devicetree/bindings/net/can/rcar_can.txt | 12 +--
.../devicetree/bindings/net/can/rcar_canfd.txt | 16 ++--
.../devicetree/bindings/vendor-prefixes.txt | 1 +
arch/arm64/boot/dts/renesas/Makefile | 1 +
arch/arm64/boot/dts/renesas/cat875.dtsi | 40 +++++++++
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 97 ++++++++++++++++++++++
arch/arm64/boot/dts/renesas/r8a774c0-ek874.dts | 14 ++++
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 12 ++-
drivers/clk/renesas/r8a774c0-cpg-mssr.c | 4 +
include/dt-bindings/clock/r8a774c0-cpg-mssr.h | 17 ++--
11 files changed, 194 insertions(+), 28 deletions(-)
create mode 100644 arch/arm64/boot/dts/renesas/cat875.dtsi
create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
create mode 100644 arch/arm64/boot/dts/renesas/r8a774c0-ek874.dts

--
2.7.4



2019-01-17 00:02:46

by Fabrizio Castro

[permalink] [raw]
Subject: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

From: Biju Das <[email protected]>

Add Silicon Linux to the list of devicetree vendor prefixes.

Website: http://www.si-linux.co.jp

Signed-off-by: Biju Das <[email protected]>
Signed-off-by: Fabrizio Castro <[email protected]>
Reviewed-by: Chris Paterson <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4b1a2a8..02a7037 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -344,6 +344,7 @@ sgx SGX Sensortech
sharp Sharp Corporation
shimafuji Shimafuji Electric, Inc.
si-en Si-En Technology Ltd.
+si-linux Silicon Linux Corporation
sifive SiFive, Inc.
sigma Sigma Designs, Inc.
sii Seiko Instruments, Inc.
--
2.7.4


2019-01-17 00:03:38

by Fabrizio Castro

[permalink] [raw]
Subject: [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support

Document the support for rcar_canfd on R8A774C0 SoC devices.

Signed-off-by: Fabrizio Castro <[email protected]>
Reviewed-by: Chris Paterson <[email protected]>
---
This patch depends on:
https://patchwork.kernel.org/patch/10687999/
https://patchwork.kernel.org/patch/10688001/

Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
index 41049fe..32f051f 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
@@ -3,7 +3,8 @@ Renesas R-Car CAN FD controller Device Tree Bindings

Required properties:
- compatible: Must contain one or more of the following:
- - "renesas,rcar-gen3-canfd" for R-Car Gen3 compatible controller.
+ - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
+ - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
- "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
- "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
- "renesas,r8a77965-canfd" for R8A77965 (R-Car M3-N) compatible controller.
@@ -28,12 +29,13 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
child node supports the "status" property only, which is used to
enable/disable the respective channel.

-Required properties for "renesas,r8a7795-canfd", "renesas,r8a7796-canfd",
-"renesas,r8a77965-canfd" and "renesas,r8a77990-canfd" compatible:
-In R8A7795, R8A7796, R8A77965 and R8A77990 SoCs, canfd clock is a div6 clock
-and can be used by both CAN and CAN FD controller at the same time. It needs
-to be scaled to maximum frequency if any of these controllers use it. This is
-done using the below properties:
+Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
+"renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
+compatible:
+In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
+div6 clock and can be used by both CAN and CAN FD controller at the same time.
+It needs to be scaled to maximum frequency if any of these controllers use it.
+This is done using the below properties:

- assigned-clocks: phandle of canfd clock.
- assigned-clock-rates: maximum frequency of this clock.
--
2.7.4


2019-01-17 06:37:34

by Fabrizio Castro

[permalink] [raw]
Subject: [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks

According to the latest information, the clock options for CAN on RZ/G2
are the same as the ones available on R-Car Gen3

Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support")
Signed-off-by: Fabrizio Castro <[email protected]>
Reviewed-by: Chris Paterson <[email protected]>
---
Documentation/devicetree/bindings/net/can/rcar_can.txt | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
index 7fcf501..b463e12 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
@@ -28,13 +28,8 @@ Required properties:

- reg: physical base address and size of the R-Car CAN register map.
- interrupts: interrupt specifier for the sole interrupt.
-- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2
- devices.
- phandles and clock specifiers for 3 CAN clock inputs for every other
- SoC.
-- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk".
- 3 clock input name strings for every other SoC: "clkp1", "clkp2",
- "can_clk".
+- clocks: phandles and clock specifiers for 3 CAN clock inputs.
+- clock-names: 3 clock input name strings: "clkp1", "clkp2", and "can_clk".
- pinctrl-0: pin control group to be used for this controller.
- pinctrl-names: must be "default".

@@ -50,8 +45,7 @@ using the below properties:
Optional properties:
- renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are:
<0x0> (default) : Peripheral clock (clkp1)
- <0x1> : Peripheral clock (clkp2) (not supported by
- RZ/G2 devices)
+ <0x1> : Peripheral clock (clkp2)
<0x3> : External input clock

Example
--
2.7.4


2019-01-17 11:49:42

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

On Wed, Jan 16, 2019 at 06:37:44PM +0000, Fabrizio Castro wrote:
> From: Biju Das <[email protected]>
>
> Add Silicon Linux to the list of devicetree vendor prefixes.
>
> Website: http://www.si-linux.co.jp
>
> Signed-off-by: Biju Das <[email protected]>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 4b1a2a8..02a7037 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -344,6 +344,7 @@ sgx SGX Sensortech
> sharp Sharp Corporation
> shimafuji Shimafuji Electric, Inc.
> si-en Si-En Technology Ltd.
> +si-linux Silicon Linux Corporation
> sifive SiFive, Inc.
> sigma Sigma Designs, Inc.
> sii Seiko Instruments, Inc.
> --
> 2.7.4
>

2019-01-17 11:51:13

by Andreas Färber

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Hi Fabrizio,

Am 16.01.19 um 19:37 schrieb Fabrizio Castro:
> From: Biju Das <[email protected]>
>
> Add Silicon Linux to the list of devicetree vendor prefixes.
>
> Website: http://www.si-linux.co.jp
>
> Signed-off-by: Biju Das <[email protected]>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 4b1a2a8..02a7037 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -344,6 +344,7 @@ sgx SGX Sensortech
> sharp Sharp Corporation
> shimafuji Shimafuji Electric, Inc.
> si-en Si-En Technology Ltd.
> +si-linux Silicon Linux Corporation

With the website being Japanese only, I haven't been able to confirm the
spelling of the company name. Looks sensible though.

Due to "en" coming before "five" I've double-checked that elsewhere we
do order dashes before letters, so placement in file and tab-indentation
is fine, too.

> sifive SiFive, Inc.
> sigma Sigma Designs, Inc.
> sii Seiko Instruments, Inc.

Personally I would drop the full stop at the end of the subject, but anyway:

Reviewed-by: Andreas Färber <[email protected]>

Thanks,
Andreas

P.S. Please double-check how this excessive CC list came to life!

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

2019-01-17 12:09:03

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks

On Wed, Jan 16, 2019 at 06:37:52PM +0000, Fabrizio Castro wrote:
> According to the latest information, the clock options for CAN on RZ/G2
> are the same as the ones available on R-Car Gen3

I'm taking your word for the above.
As the patch matches the description:

Reviewed-by: Simon Horman <[email protected]>

> Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support")
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/rcar_can.txt | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> index 7fcf501..b463e12 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> @@ -28,13 +28,8 @@ Required properties:
>
> - reg: physical base address and size of the R-Car CAN register map.
> - interrupts: interrupt specifier for the sole interrupt.
> -- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2
> - devices.
> - phandles and clock specifiers for 3 CAN clock inputs for every other
> - SoC.
> -- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk".
> - 3 clock input name strings for every other SoC: "clkp1", "clkp2",
> - "can_clk".
> +- clocks: phandles and clock specifiers for 3 CAN clock inputs.
> +- clock-names: 3 clock input name strings: "clkp1", "clkp2", and "can_clk".
> - pinctrl-0: pin control group to be used for this controller.
> - pinctrl-names: must be "default".
>
> @@ -50,8 +45,7 @@ using the below properties:
> Optional properties:
> - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are:
> <0x0> (default) : Peripheral clock (clkp1)
> - <0x1> : Peripheral clock (clkp2) (not supported by
> - RZ/G2 devices)
> + <0x1> : Peripheral clock (clkp2)
> <0x3> : External input clock
>
> Example
> --
> 2.7.4
>

2019-01-17 12:13:58

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support

On Wed, Jan 16, 2019 at 06:37:54PM +0000, Fabrizio Castro wrote:
> Document the support for rcar_canfd on R8A774C0 SoC devices.
>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10687999/
> https://patchwork.kernel.org/patch/10688001/
>
> Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 16 +++++++++-------

Reviewed-by: Simon Horman <[email protected]>

> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> index 41049fe..32f051f 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> @@ -3,7 +3,8 @@ Renesas R-Car CAN FD controller Device Tree Bindings
>
> Required properties:
> - compatible: Must contain one or more of the following:
> - - "renesas,rcar-gen3-canfd" for R-Car Gen3 compatible controller.
> + - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
> + - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
> - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
> - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> - "renesas,r8a77965-canfd" for R8A77965 (R-Car M3-N) compatible controller.
> @@ -28,12 +29,13 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
> child node supports the "status" property only, which is used to
> enable/disable the respective channel.
>
> -Required properties for "renesas,r8a7795-canfd", "renesas,r8a7796-canfd",
> -"renesas,r8a77965-canfd" and "renesas,r8a77990-canfd" compatible:
> -In R8A7795, R8A7796, R8A77965 and R8A77990 SoCs, canfd clock is a div6 clock
> -and can be used by both CAN and CAN FD controller at the same time. It needs
> -to be scaled to maximum frequency if any of these controllers use it. This is
> -done using the below properties:
> +Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
> +"renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
> +compatible:
> +In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
> +div6 clock and can be used by both CAN and CAN FD controller at the same time.
> +It needs to be scaled to maximum frequency if any of these controllers use it.
> +This is done using the below properties:
>
> - assigned-clocks: phandle of canfd clock.
> - assigned-clock-rates: maximum frequency of this clock.
> --
> 2.7.4
>

2019-01-17 14:01:29

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

On Thu, Jan 17, 2019 at 12:17:56PM +0100, Andreas Färber wrote:
> Hi Fabrizio,
>
> Am 16.01.19 um 19:37 schrieb Fabrizio Castro:
> > From: Biju Das <[email protected]>
> >
> > Add Silicon Linux to the list of devicetree vendor prefixes.
> >
> > Website: http://www.si-linux.co.jp
> >
> > Signed-off-by: Biju Das <[email protected]>
> > Signed-off-by: Fabrizio Castro <[email protected]>
> > Reviewed-by: Chris Paterson <[email protected]>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 4b1a2a8..02a7037 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -344,6 +344,7 @@ sgx SGX Sensortech
> > sharp Sharp Corporation
> > shimafuji Shimafuji Electric, Inc.
> > si-en Si-En Technology Ltd.
> > +si-linux Silicon Linux Corporation
>
> With the website being Japanese only, I haven't been able to confirm the
> spelling of the company name. Looks sensible though.

According to the company web site
(http://si-linux.co.jp/index.php?%E4%BC%9A%E7%A4%BE%E6%A1%88%E5%86%85)
the company name is.

Japanese: シリコンリナックス株式会社
English: Silicon Linux Corporation

And in my opinion these are equivalent (although other translations of
the corporation bit are possible).

> Due to "en" coming before "five" I've double-checked that elsewhere we
> do order dashes before letters, so placement in file and tab-indentation
> is fine, too.
>
> > sifive SiFive, Inc.
> > sigma Sigma Designs, Inc.
> > sii Seiko Instruments, Inc.
>
> Personally I would drop the full stop at the end of the subject, but anyway:
>
> Reviewed-by: Andreas Färber <[email protected]>
>
> Thanks,
> Andreas
>
> P.S. Please double-check how this excessive CC list came to life!
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
>

2019-01-17 14:16:28

by Chris Paterson

[permalink] [raw]
Subject: RE: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Hello Andreas, Simon,

Thank you for your reviews.

> From: Simon Horman <[email protected]>
> Sent: 17 January 2019 12:19
>
> On Thu, Jan 17, 2019 at 12:17:56PM +0100, Andreas Färber wrote:
> > Hi Fabrizio,
> >
> > Am 16.01.19 um 19:37 schrieb Fabrizio Castro:
> > > From: Biju Das <[email protected]>
> > >
> > > Add Silicon Linux to the list of devicetree vendor prefixes.
> > >
> > > Website: http://www.si-linux.co.jp
> > >
> > > Signed-off-by: Biju Das <[email protected]>
> > > Signed-off-by: Fabrizio Castro <[email protected]>
> > > Reviewed-by: Chris Paterson <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > index 4b1a2a8..02a7037 100644
> > > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > @@ -344,6 +344,7 @@ sgx SGX Sensortech
> > > sharp Sharp Corporation
> > > shimafuji Shimafuji Electric, Inc.
> > > si-en Si-En Technology Ltd.
> > > +si-linux Silicon Linux Corporation
> >
> > With the website being Japanese only, I haven't been able to confirm the
> > spelling of the company name. Looks sensible though.
>
> According to the company web site
> (http://si-
> linux.co.jp/index.php?%E4%BC%9A%E7%A4%BE%E6%A1%88%E5%86%85)
> the company name is.
>
> Japanese: シリコンリナックス株式会社
> English: Silicon Linux Corporation

I can also confirm that this is what we've been told by Si-Linux themselves ????

Kind regards, Chris

>
> And in my opinion these are equivalent (although other translations of
> the corporation bit are possible).
>
> > Due to "en" coming before "five" I've double-checked that elsewhere we
> > do order dashes before letters, so placement in file and tab-indentation
> > is fine, too.
> >
> > > sifive SiFive, Inc.
> > > sigma Sigma Designs, Inc.
> > > sii Seiko Instruments, Inc.
> >
> > Personally I would drop the full stop at the end of the subject, but anyway:
> >
> > Reviewed-by: Andreas Färber <[email protected]>
> >
> > Thanks,
> > Andreas
> >
> > P.S. Please double-check how this excessive CC list came to life!
> >
> > --
> > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> > GF: Felix Imendörffer, Jane Smithard, Graham Norton
> > HRB 21284 (AG Nürnberg)
> >

2019-01-22 01:15:53

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

On Wed, 16 Jan 2019 18:37:44 +0000, Fabrizio Castro wrote:
> From: Biju Das <[email protected]>
>
> Add Silicon Linux to the list of devicetree vendor prefixes.
>
> Website: http://www.si-linux.co.jp
>
> Signed-off-by: Biju Das <[email protected]>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Rob Herring <[email protected]>

2019-01-22 01:16:39

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks

On Wed, 16 Jan 2019 18:37:52 +0000, Fabrizio Castro wrote:
> According to the latest information, the clock options for CAN on RZ/G2
> are the same as the ones available on R-Car Gen3
>
> Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support")
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/rcar_can.txt | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2019-01-22 01:18:20

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support

On Wed, 16 Jan 2019 18:37:54 +0000, Fabrizio Castro wrote:
> Document the support for rcar_canfd on R8A774C0 SoC devices.
>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10687999/
> https://patchwork.kernel.org/patch/10688001/
>
> Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2019-02-15 00:52:55

by Fabrizio Castro

[permalink] [raw]
Subject: RE: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Dear All,

Who is the best person for taking this patch?

Thanks,
Fab

> From: Fabrizio Castro <[email protected]>
> Sent: 16 January 2019 18:38
> Subject: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.
>
> From: Biju Das <[email protected]>
>
> Add Silicon Linux to the list of devicetree vendor prefixes.
>
> Website: http://www.si-linux.co.jp
>
> Signed-off-by: Biju Das <[email protected]>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 4b1a2a8..02a7037 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -344,6 +344,7 @@ sgxSGX Sensortech
> sharpSharp Corporation
> shimafujiShimafuji Electric, Inc.
> si-enSi-En Technology Ltd.
> +si-linuxSilicon Linux Corporation
> sifiveSiFive, Inc.
> sigmaSigma Designs, Inc.
> siiSeiko Instruments, Inc.
> --
> 2.7.4



Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

2019-02-15 15:18:03

by Lukasz Majewski

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Hi Fabrizio,

The best approach is to run:

git format patch -1 <your patch sha>

And then

scripts/get_maintainer.pl 0001-xxxxxxx

You shall see the the list of people to send the patch.

> Dear All,
>
> Who is the best person for taking this patch?
>
> Thanks,
> Fab
>
> > From: Fabrizio Castro <[email protected]>
> > Sent: 16 January 2019 18:38
> > Subject: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon
> > Linux.
> >
> > From: Biju Das <[email protected]>
> >
> > Add Silicon Linux to the list of devicetree vendor prefixes.
> >
> > Website: http://www.si-linux.co.jp
> >
> > Signed-off-by: Biju Das <[email protected]>
> > Signed-off-by: Fabrizio Castro <[email protected]>
> > Reviewed-by: Chris Paterson <[email protected]>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> > 4b1a2a8..02a7037 100644 ---
> > a/Documentation/devicetree/bindings/vendor-prefixes.txt +++
> > b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -344,6
> > +344,7 @@ sgxSGX Sensortech sharpSharp Corporation
> > shimafujiShimafuji Electric, Inc.
> > si-enSi-En Technology Ltd.
> > +si-linuxSilicon Linux Corporation
> > sifiveSiFive, Inc.
> > sigmaSigma Designs, Inc.
> > siiSeiko Instruments, Inc.
> > --
> > 2.7.4
>
>
>
> Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael
> Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf,
> Arcadiastrasse 10, 40472 Duesseldorf,
> Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708
> USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE
> reg. no.: DE 14978647




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-02-15 15:40:07

by Andreas Färber

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Hi Lukasz and Fabrizio,

Am 15.02.19 um 07:52 schrieb Lukasz Majewski:
> The best approach is to run:
>
> git format patch -1 <your patch sha>
>
> And then
>
> scripts/get_maintainer.pl 0001-xxxxxxx
>
> You shall see the the list of people to send the patch.

No, that does not answer his question. And please don't top-post.

>> Who is the best person for taking this patch?

The answer is: whomever is taking dt-bindings patches in the following
10 patches that make use of this prefix, once you have a Reviewed-by
from Rob. So, most likely the Renesas kernel maintainer(s), i.e. Simon,
which differs from get_maintainers.pl of vendor-prefixes.txt.

Regards,
Andreas

>>> From: Fabrizio Castro <[email protected]>
>>> Sent: 16 January 2019 18:38
>>> Subject: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon
>>> Linux.
>>>
>>> From: Biju Das <[email protected]>
>>>
>>> Add Silicon Linux to the list of devicetree vendor prefixes.
>>>
>>> Website: http://www.si-linux.co.jp
>>>
>>> Signed-off-by: Biju Das <[email protected]>
>>> Signed-off-by: Fabrizio Castro <[email protected]>
>>> Reviewed-by: Chris Paterson <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
>>> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
>>> 4b1a2a8..02a7037 100644 ---
>>> a/Documentation/devicetree/bindings/vendor-prefixes.txt +++
>>> b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -344,6
>>> +344,7 @@ sgxSGX Sensortech sharpSharp Corporation
>>> shimafujiShimafuji Electric, Inc.
>>> si-enSi-En Technology Ltd.
>>> +si-linuxSilicon Linux Corporation
>>> sifiveSiFive, Inc.
>>> sigmaSigma Designs, Inc.
>>> siiSeiko Instruments, Inc.
>>> --
>>> 2.7.4
>>
>>
>>
>> Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael
>> Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf,
>> Arcadiastrasse 10, 40472 Duesseldorf,
>> Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708
>> USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE
>> reg. no.: DE 14978647
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
>


--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

2019-03-01 12:22:30

by Fabrizio Castro

[permalink] [raw]
Subject: RE: [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support

Hello Marc,

I am sorry to bother you.
Do you think you can take this patch?

Thanks,
Fab

> From: Fabrizio Castro <[email protected]>
> Sent: 16 January 2019 18:38
> Subject: [PATCH 11/11] dt-bindings: can: rcar_canfd: document r8a774c0 support
>
> Document the support for rcar_canfd on R8A774C0 SoC devices.
>
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10687999/
> https://patchwork.kernel.org/patch/10688001/
>
> Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> index 41049fe..32f051f 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> @@ -3,7 +3,8 @@ Renesas R-Car CAN FD controller Device Tree Bindings
>
> Required properties:
> - compatible: Must contain one or more of the following:
> - - "renesas,rcar-gen3-canfd" for R-Car Gen3 compatible controller.
> + - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
> + - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
> - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
> - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> - "renesas,r8a77965-canfd" for R8A77965 (R-Car M3-N) compatible controller.
> @@ -28,12 +29,13 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
> child node supports the "status" property only, which is used to
> enable/disable the respective channel.
>
> -Required properties for "renesas,r8a7795-canfd", "renesas,r8a7796-canfd",
> -"renesas,r8a77965-canfd" and "renesas,r8a77990-canfd" compatible:
> -In R8A7795, R8A7796, R8A77965 and R8A77990 SoCs, canfd clock is a div6 clock
> -and can be used by both CAN and CAN FD controller at the same time. It needs
> -to be scaled to maximum frequency if any of these controllers use it. This is
> -done using the below properties:
> +Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
> +"renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
> +compatible:
> +In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
> +div6 clock and can be used by both CAN and CAN FD controller at the same time.
> +It needs to be scaled to maximum frequency if any of these controllers use it.
> +This is done using the below properties:
>
> - assigned-clocks: phandle of canfd clock.
> - assigned-clock-rates: maximum frequency of this clock.
> --
> 2.7.4


2019-03-01 12:22:55

by Fabrizio Castro

[permalink] [raw]
Subject: RE: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Thank you Andreas.

> From: Andreas F?rber <[email protected]>
> Sent: 15 February 2019 09:10
> Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.
>
> Hi Lukasz and Fabrizio,
>
> Am 15.02.19 um 07:52 schrieb Lukasz Majewski:
> > The best approach is to run:
> >
> > git format patch -1 <your patch sha>
> >
> > And then
> >
> > scripts/get_maintainer.pl 0001-xxxxxxx
> >
> > You shall see the the list of people to send the patch.
>
> No, that does not answer his question. And please don't top-post.
>
> >> Who is the best person for taking this patch?
>
> The answer is: whomever is taking dt-bindings patches in the following
> 10 patches that make use of this prefix, once you have a Reviewed-by
> from Rob. So, most likely the Renesas kernel maintainer(s), i.e. Simon,
> which differs from get_maintainers.pl of vendor-prefixes.txt.

Simon, do you think you can take this patch?

Thanks,
Fab

>
> Regards,
> Andreas
>
> >>> From: Fabrizio Castro <[email protected]>
> >>> Sent: 16 January 2019 18:38
> >>> Subject: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon
> >>> Linux.
> >>>
> >>> From: Biju Das <[email protected]>
> >>>
> >>> Add Silicon Linux to the list of devicetree vendor prefixes.
> >>>
> >>> Website: http://www.si-linux.co.jp
> >>>
> >>> Signed-off-by: Biju Das <[email protected]>
> >>> Signed-off-by: Fabrizio Castro <[email protected]>
> >>> Reviewed-by: Chris Paterson <[email protected]>
> >>> ---
> >>> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> >>> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> >>> 4b1a2a8..02a7037 100644 ---
> >>> a/Documentation/devicetree/bindings/vendor-prefixes.txt +++
> >>> b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -344,6
> >>> +344,7 @@ sgxSGX Sensortech sharpSharp Corporation
> >>> shimafujiShimafuji Electric, Inc.
> >>> si-enSi-En Technology Ltd.
> >>> +si-linuxSilicon Linux Corporation
> >>> sifiveSiFive, Inc.
> >>> sigmaSigma Designs, Inc.
> >>> siiSeiko Instruments, Inc.
> >>> --
> >>> 2.7.4
> >>
> >>
> >>
> >> Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael
> >> Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf,
> >> Arcadiastrasse 10, 40472 Duesseldorf,
> >> Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708
> >> USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE
> >> reg. no.: DE 14978647
> >
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
> >
>
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
> GF: Felix Imend?rffer, Jane Smithard, Graham Norton
> HRB 21284 (AG N?rnberg)

2019-03-01 12:53:16

by Fabrizio Castro

[permalink] [raw]
Subject: RE: [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks

Hello Marc,

I am sorry to bother you.
Do you think you can take this patch?

Thanks,
Fab

> From: Fabrizio Castro <[email protected]>
> Sent: 16 January 2019 18:38
> Subject: [PATCH 09/11] dt-bindings: can: rcar_can: Fix RZ/G2 CAN clocks
>
> According to the latest information, the clock options for CAN on RZ/G2
> are the same as the ones available on R-Car Gen3
>
> Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support")
> Signed-off-by: Fabrizio Castro <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/rcar_can.txt | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> index 7fcf501..b463e12 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> @@ -28,13 +28,8 @@ Required properties:
>
> - reg: physical base address and size of the R-Car CAN register map.
> - interrupts: interrupt specifier for the sole interrupt.
> -- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2
> - devices.
> - phandles and clock specifiers for 3 CAN clock inputs for every other
> - SoC.
> -- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk".
> - 3 clock input name strings for every other SoC: "clkp1", "clkp2",
> - "can_clk".
> +- clocks: phandles and clock specifiers for 3 CAN clock inputs.
> +- clock-names: 3 clock input name strings: "clkp1", "clkp2", and "can_clk".
> - pinctrl-0: pin control group to be used for this controller.
> - pinctrl-names: must be "default".
>
> @@ -50,8 +45,7 @@ using the below properties:
> Optional properties:
> - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are:
> <0x0> (default) : Peripheral clock (clkp1)
> - <0x1> : Peripheral clock (clkp2) (not supported by
> - RZ/G2 devices)
> + <0x1> : Peripheral clock (clkp2)
> <0x3> : External input clock
>
> Example
> --
> 2.7.4


2019-03-04 09:42:54

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

On Fri, Mar 01, 2019 at 12:03:06PM +0000, Fabrizio Castro wrote:
> Thank you Andreas.
>
> > From: Andreas Färber <[email protected]>
> > Sent: 15 February 2019 09:10
> > Subject: Re: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.
> >
> > Hi Lukasz and Fabrizio,
> >
> > Am 15.02.19 um 07:52 schrieb Lukasz Majewski:
> > > The best approach is to run:
> > >
> > > git format patch -1 <your patch sha>
> > >
> > > And then
> > >
> > > scripts/get_maintainer.pl 0001-xxxxxxx
> > >
> > > You shall see the the list of people to send the patch.
> >
> > No, that does not answer his question. And please don't top-post.
> >
> > >> Who is the best person for taking this patch?
> >
> > The answer is: whomever is taking dt-bindings patches in the following
> > 10 patches that make use of this prefix, once you have a Reviewed-by
> > from Rob. So, most likely the Renesas kernel maintainer(s), i.e. Simon,
> > which differs from get_maintainers.pl of vendor-prefixes.txt.
>
> Simon, do you think you can take this patch?

Sure, I have queued it up for v5.2.

>
> Thanks,
> Fab
>
> >
> > Regards,
> > Andreas
> >
> > >>> From: Fabrizio Castro <[email protected]>
> > >>> Sent: 16 January 2019 18:38
> > >>> Subject: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon
> > >>> Linux.
> > >>>
> > >>> From: Biju Das <[email protected]>
> > >>>
> > >>> Add Silicon Linux to the list of devicetree vendor prefixes.
> > >>>
> > >>> Website: http://www.si-linux.co.jp
> > >>>
> > >>> Signed-off-by: Biju Das <[email protected]>
> > >>> Signed-off-by: Fabrizio Castro <[email protected]>
> > >>> Reviewed-by: Chris Paterson <[email protected]>
> > >>> ---
> > >>> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> > >>> 1 file changed, 1 insertion(+)
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > >>> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> > >>> 4b1a2a8..02a7037 100644 ---
> > >>> a/Documentation/devicetree/bindings/vendor-prefixes.txt +++
> > >>> b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -344,6
> > >>> +344,7 @@ sgxSGX Sensortech sharpSharp Corporation
> > >>> shimafujiShimafuji Electric, Inc.
> > >>> si-enSi-En Technology Ltd.
> > >>> +si-linuxSilicon Linux Corporation
> > >>> sifiveSiFive, Inc.
> > >>> sigmaSigma Designs, Inc.
> > >>> siiSeiko Instruments, Inc.
> > >>> --
> > >>> 2.7.4
> > >>
> > >>
> > >>
> > >> Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael
> > >> Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf,
> > >> Arcadiastrasse 10, 40472 Duesseldorf,
> > >> Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708
> > >> USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE
> > >> reg. no.: DE 14978647
> > >
> > >
> > >
> > >
> > > Best regards,
> > >
> > > Lukasz Majewski
> > >
> > > --
> > >
> > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
> > >
> >
> >
> > --
> > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> > GF: Felix Imendörffer, Jane Smithard, Graham Norton
> > HRB 21284 (AG Nürnberg)
>