2008-11-20 20:25:38

by Hannes Eder

Subject: [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static

Fix the following sparse warnings:

sound/sound_core.c:460:2: warning: returning void-valued expression
sound/sound_core.c:477:2: warning: returning void-valued expression
sound/sound_core.c:510:5: warning: symbol 'soundcore_open' was not
declared. Should it be static?

Signed-off-by: Hannes Eder <[email protected]>
---
sound/sound_core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/sound_core.c b/sound/sound_core.c
index a75b289..10ba421 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -457,7 +457,7 @@ EXPORT_SYMBOL(unregister_sound_mixer);

void unregister_sound_midi(int unit)
{
- return sound_remove_unit(&chains[2], unit);
+ sound_remove_unit(&chains[2], unit);
}

EXPORT_SYMBOL(unregister_sound_midi);
@@ -474,7 +474,7 @@ EXPORT_SYMBOL(unregister_sound_midi);

void unregister_sound_dsp(int unit)
{
- return sound_remove_unit(&chains[3], unit);
+ sound_remove_unit(&chains[3], unit);
}


@@ -507,7 +507,7 @@ static struct sound_unit *__look_for_unit(int
chain, int unit)
return NULL;
}

-int soundcore_open(struct inode *inode, struct file *file)
+static int soundcore_open(struct inode *inode, struct file *file)
{
int chain;
int unit = iminor(inode);

2008-11-21 07:43:38

by Takashi Iwai

Subject: Re: [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static

At Thu, 20 Nov 2008 21:25:25 +0100,
Hannes Eder wrote:
>
> Fix the following sparse warnings:
>
> sound/sound_core.c:460:2: warning: returning void-valued expression
> sound/sound_core.c:477:2: warning: returning void-valued expression
> sound/sound_core.c:510:5: warning: symbol 'soundcore_open' was not
> declared. Should it be static?
>
> Signed-off-by: Hannes Eder <[email protected]>

Thanks, applied now.


Takashi

> ---
> sound/sound_core.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/sound_core.c b/sound/sound_core.c
> index a75b289..10ba421 100644
> --- a/sound/sound_core.c
> +++ b/sound/sound_core.c
> @@ -457,7 +457,7 @@ EXPORT_SYMBOL(unregister_sound_mixer);
>
> void unregister_sound_midi(int unit)
> {
> - return sound_remove_unit(&chains[2], unit);
> + sound_remove_unit(&chains[2], unit);
> }
>
> EXPORT_SYMBOL(unregister_sound_midi);
> @@ -474,7 +474,7 @@ EXPORT_SYMBOL(unregister_sound_midi);
>
> void unregister_sound_dsp(int unit)
> {
> - return sound_remove_unit(&chains[3], unit);
> + sound_remove_unit(&chains[3], unit);
> }
>
>
> @@ -507,7 +507,7 @@ static struct sound_unit *__look_for_unit(int
> chain, int unit)
> return NULL;
> }
>
> -int soundcore_open(struct inode *inode, struct file *file)
> +static int soundcore_open(struct inode *inode, struct file *file)
> {
> int chain;
> int unit = iminor(inode);
>