2019-02-14 11:23:22

by Huang Zijiang

[permalink] [raw]
Subject: [PATCH] net:dl2k: Replace dev_kfree_skb_irq by dev_consume_skb_irq

dev_consume_skb_irq() should be called when skb xmit
done.It makes drop profiles more friendly.

Signed-off-by: Huang Zijiang <[email protected]>
---
drivers/net/ethernet/dlink/dl2k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c
index f0536b1..21810bf 100644
--- a/drivers/net/ethernet/dlink/dl2k.c
+++ b/drivers/net/ethernet/dlink/dl2k.c
@@ -843,7 +843,7 @@ rio_free_tx (struct net_device *dev, int irq)
desc_to_dma(&np->tx_ring[entry]),
skb->len, PCI_DMA_TODEVICE);
if (irq)
- dev_kfree_skb_irq(skb);
+ dev_consume_skb_irq(skb);
else
dev_kfree_skb(skb);

--
1.8.3.1



2019-02-15 01:08:22

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net:dl2k: Replace dev_kfree_skb_irq by dev_consume_skb_irq

From: Huang Zijiang <[email protected]>
Date: Thu, 14 Feb 2019 14:40:56 +0800

> dev_consume_skb_irq() should be called when skb xmit
> done.It makes drop profiles more friendly.
>
> Signed-off-by: Huang Zijiang <[email protected]>

Applied.