2019-02-14 11:24:39

by Huang Zijiang

Subject: [PATCH] sched/core: Remove BUG_ON()

pick_next_task is never return NULL because idle task
will return when cpu is idle.

Signed-off-by: Huang Zijiang <[email protected]>
---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index dbe9a3f..1de1a85 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5624,7 +5624,6 @@ static void migrate_tasks(struct rq *dead_rq, struct rq_flags *rf)
* * pick_next_task() assumes pinned rq->lock:
* */
next = pick_next_task(rq, &fake_task, rf);
- BUG_ON(!next);
put_prev_task(rq, next);

/*
--
1.8.3.1

2019-02-14 17:58:36

by Peter Zijlstra

Subject: Re: [PATCH] sched/core: Remove BUG_ON()

On Thu, Feb 14, 2019 at 02:42:37PM +0800, Huang Zijiang wrote:
> pick_next_task is never return NULL because idle task
> will return when cpu is idle.

And to be sure it does; we have that BUG_ON :-)