2019-02-19 15:02:18

by Colin King

Subject: [PATCH][next] drm/i915/selftests: fix memory leak of 'spin'

From: Colin Ian King <[email protected]>

There is a memory leak of 'spin' on an error return path. Fix this by
kfree'ing spin before the return.

Fixes: c06ee6ff2cbc ("drm/i915/selftests: Context SSEU reconfiguration tests")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/i915/selftests/i915_gem_context.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
index d00d0bb07784..cf988797bb17 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
@@ -725,8 +725,10 @@ __sseu_prepare(struct drm_i915_private *i915,
}

ret = igt_spinner_init(spin, i915);
- if (ret)
+ if (ret) {
+ kfree(spin);
return ret;
+ }

rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
if (IS_ERR(rq)) {
--
2.20.1

2019-02-19 15:09:58

by Chris Wilson

Subject: Re: [PATCH][next] drm/i915/selftests: fix memory leak of 'spin'

Quoting Colin King (2019-02-19 15:01:29)
> From: Colin Ian King <[email protected]>
>
> There is a memory leak of 'spin' on an error return path. Fix this by
> kfree'ing spin before the return.
>
> Fixes: c06ee6ff2cbc ("drm/i915/selftests: Context SSEU reconfiguration tests")
> Signed-off-by: Colin Ian King <[email protected]>

I hope already fixed by

commit 2a4a2754039594c60b58b02b6781428a85f6d745
Author: Chris Wilson <[email protected]>
Date: Fri Feb 15 19:50:10 2019 +0000

drm/i915/selftests: Always free spinner on __sseu_prepare error

Thanks,
-Chris