2019-03-22 07:01:59

by Frank Rowand

Subject: [PATCH v2] tracing: initialize variable in create_dyn_event()

From: Frank Rowand <[email protected]>

Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
in this function [-Wuninitialized].

Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")

Signed-off-by: Frank Rowand <[email protected]>
---

changes since v1:
- initialize to -ENODEV instead of 0, as suggested by Steve

kernel/trace/trace_dynevent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
index dd1f43588d70..fa100ed3b4de 100644
--- a/kernel/trace/trace_dynevent.c
+++ b/kernel/trace/trace_dynevent.c
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
static int create_dyn_event(int argc, char **argv)
{
struct dyn_event_operations *ops;
- int ret;
+ int ret = -ENODEV;

if (argv[0][0] == '-' || argv[0][0] == '!')
return dyn_event_release(argc, argv, NULL);
--
Frank Rowand <[email protected]>

2019-03-22 19:20:56

by Steven Rostedt

Subject: Re: [PATCH v2] tracing: initialize variable in create_dyn_event()

On Thu, 21 Mar 2019 23:58:20 -0700
[email protected] wrote:

> From: Frank Rowand <[email protected]>
>
> Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
> in this function [-Wuninitialized].
>
> Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
>
> Signed-off-by: Frank Rowand <[email protected]>

Applied. Thanks Frank!

-- Steve

> ---
>
> changes since v1:
> - initialize to -ENODEV instead of 0, as suggested by Steve
>
> kernel/trace/trace_dynevent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> index dd1f43588d70..fa100ed3b4de 100644
> --- a/kernel/trace/trace_dynevent.c
> +++ b/kernel/trace/trace_dynevent.c
> @@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
> static int create_dyn_event(int argc, char **argv)
> {
> struct dyn_event_operations *ops;
> - int ret;
> + int ret = -ENODEV;
>
> if (argv[0][0] == '-' || argv[0][0] == '!')
> return dyn_event_release(argc, argv, NULL);

2019-03-23 10:31:54

by Masami Hiramatsu

Subject: Re: [PATCH v2] tracing: initialize variable in create_dyn_event()

On Fri, 22 Mar 2019 15:20:00 -0400
Steven Rostedt <[email protected]> wrote:

> On Thu, 21 Mar 2019 23:58:20 -0700
> [email protected] wrote:
>
> > From: Frank Rowand <[email protected]>
> >
> > Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
> > in this function [-Wuninitialized].
> >
> > Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
> >
> > Signed-off-by: Frank Rowand <[email protected]>
>
> Applied. Thanks Frank!

Thank you Frank and Steve,

feel free to add my ack.

Acked-by: Masami Hiramatsu <[email protected]>

Thanks!

>
> -- Steve
>
> > ---
> >
> > changes since v1:
> > - initialize to -ENODEV instead of 0, as suggested by Steve
> >
> > kernel/trace/trace_dynevent.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> > index dd1f43588d70..fa100ed3b4de 100644
> > --- a/kernel/trace/trace_dynevent.c
> > +++ b/kernel/trace/trace_dynevent.c
> > @@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
> > static int create_dyn_event(int argc, char **argv)
> > {
> > struct dyn_event_operations *ops;
> > - int ret;
> > + int ret = -ENODEV;
> >
> > if (argv[0][0] == '-' || argv[0][0] == '!')
> > return dyn_event_release(argc, argv, NULL);
>


--
Masami Hiramatsu <[email protected]>