2019-03-26 12:19:42

by Mukesh Ojha

Subject: [PATCH] media: vpss: fix the order of resource clean up

Clean up of resources should be in reverse order of vpss_init().
Fix this inside vpss_exit().

Signed-off-by: Mukesh Ojha <[email protected]>
---
drivers/media/platform/davinci/vpss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c
index 19cf685..e380fd3 100644
--- a/drivers/media/platform/davinci/vpss.c
+++ b/drivers/media/platform/davinci/vpss.c
@@ -507,9 +507,9 @@ static int vpss_resume(struct device *dev)

static void vpss_exit(void)
{
+ platform_driver_unregister(&vpss_driver);
iounmap(oper_cfg.vpss_regs_base2);
release_mem_region(VPSS_CLK_CTRL, 4);
- platform_driver_unregister(&vpss_driver);
}

static int __init vpss_init(void)
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2019-04-01 07:27:37

by Lad, Prabhakar

Subject: Re: [PATCH] media: vpss: fix the order of resource clean up

On Tue, Mar 26, 2019 at 12:18 PM Mukesh Ojha <[email protected]> wrote:
>
> Clean up of resources should be in reverse order of vpss_init().
> Fix this inside vpss_exit().
>
> Signed-off-by: Mukesh Ojha <[email protected]>
> ---
> drivers/media/platform/davinci/vpss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Lad, Prabhakar <[email protected]>

Cheers,
--Prabhakar Lad

> diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c
> index 19cf685..e380fd3 100644
> --- a/drivers/media/platform/davinci/vpss.c
> +++ b/drivers/media/platform/davinci/vpss.c
> @@ -507,9 +507,9 @@ static int vpss_resume(struct device *dev)
>
> static void vpss_exit(void)
> {
> + platform_driver_unregister(&vpss_driver);
> iounmap(oper_cfg.vpss_regs_base2);
> release_mem_region(VPSS_CLK_CTRL, 4);
> - platform_driver_unregister(&vpss_driver);
> }
>
> static int __init vpss_init(void)
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>