2019-04-24 12:53:10

by Fabien DESSENNE

Subject: [PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe

This patchset adds some check of the returned error code in probe.

Fabien Dessenne (2):
iio: adc: stm32-dfsdm: manage the get_irq error case
iio: adc: stm32-dfsdm: missing error case during probe

drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
2 files changed, 12 insertions(+), 2 deletions(-)

--
2.7.4

2019-04-24 12:53:16

by Fabien DESSENNE

Subject: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

During probe, check the "get_irq" error value.

Signed-off-by: Fabien Dessenne <[email protected]>
---
drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 19adc2b..588907c 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
* So IRQ associated to filter instance 0 is dedicated to the Filter 0.
*/
irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ if (irq != -EPROBE_DEFER)
+ dev_err(dev, "Failed to get IRQ: %d\n", irq);
+ return irq;
+ }
+
ret = devm_request_irq(dev, irq, stm32_dfsdm_irq,
0, pdev->name, adc);
if (ret < 0) {
--
2.7.4

2019-04-24 12:57:29

by Fabrice Gasnier

Subject: Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> During probe, check the devm_ioremap_resource() error value.
> Also return the devm_clk_get() error value instead of -EINVAL.
>
> Signed-off-by: Fabien Dessenne <[email protected]>
> ---


Hi Fabien,

Acked-by: Fabrice Gasnier <[email protected]>

Thanks,
Fabrice

> drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 0a4d374..26e2011 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> }
> priv->dfsdm.phys_base = res->start;
> priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(priv->dfsdm.base))
> + return PTR_ERR(priv->dfsdm.base);
>
> /*
> * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
> @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> */
> priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
> if (IS_ERR(priv->clk)) {
> - dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
> - return -EINVAL;
> + ret = PTR_ERR(priv->clk);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
> + return ret;
> }
>
> priv->aclk = devm_clk_get(&pdev->dev, "audio");
>

2019-04-24 12:58:07

by Fabrice Gasnier

Subject: Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> During probe, check the "get_irq" error value.
>
> Signed-off-by: Fabien Dessenne <[email protected]>
> ---

Hi Fabien,

Acked-by: Fabrice Gasnier <[email protected]>

Thanks,
Fabrice

> drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 19adc2b..588907c 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
> * So IRQ associated to filter instance 0 is dedicated to the Filter 0.
> */
> irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + if (irq != -EPROBE_DEFER)
> + dev_err(dev, "Failed to get IRQ: %d\n", irq);
> + return irq;
> + }
> +
> ret = devm_request_irq(dev, irq, stm32_dfsdm_irq,
> 0, pdev->name, adc);
> if (ret < 0) {
>

2019-04-24 19:42:08

by Fabien DESSENNE

Subject: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

During probe, check the devm_ioremap_resource() error value.
Also return the devm_clk_get() error value instead of -EINVAL.

Signed-off-by: Fabien Dessenne <[email protected]>
---
drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 0a4d374..26e2011 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
}
priv->dfsdm.phys_base = res->start;
priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(priv->dfsdm.base))
+ return PTR_ERR(priv->dfsdm.base);

/*
* "dfsdm" clock is mandatory for DFSDM peripheral clocking.
@@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
*/
priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
if (IS_ERR(priv->clk)) {
- dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
- return -EINVAL;
+ ret = PTR_ERR(priv->clk);
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
+ return ret;
}

priv->aclk = devm_clk_get(&pdev->dev, "audio");
--
2.7.4

2019-04-27 13:10:46

by Jonathan Cameron

Subject: Re: [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

On Wed, 24 Apr 2019 14:55:09 +0200
Fabrice Gasnier <[email protected]> wrote:

> On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> > During probe, check the "get_irq" error value.
> >
> > Signed-off-by: Fabien Dessenne <[email protected]>
> > ---
>
> Hi Fabien,
>
> Acked-by: Fabrice Gasnier <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

>
> Thanks,
> Fabrice
>
> > drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> > index 19adc2b..588907c 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> > @@ -1456,6 +1456,12 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
> > * So IRQ associated to filter instance 0 is dedicated to the Filter 0.
> > */
> > irq = platform_get_irq(pdev, 0);
> > + if (irq < 0) {
> > + if (irq != -EPROBE_DEFER)
> > + dev_err(dev, "Failed to get IRQ: %d\n", irq);
> > + return irq;
> > + }
> > +
> > ret = devm_request_irq(dev, irq, stm32_dfsdm_irq,
> > 0, pdev->name, adc);
> > if (ret < 0) {
> >

2019-04-27 13:12:17

by Jonathan Cameron

Subject: Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

On Wed, 24 Apr 2019 14:55:28 +0200
Fabrice Gasnier <[email protected]> wrote:

> On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> > During probe, check the devm_ioremap_resource() error value.
> > Also return the devm_clk_get() error value instead of -EINVAL.
> >
> > Signed-off-by: Fabien Dessenne <[email protected]>
> > ---
>
>
> Hi Fabien,
>
> Acked-by: Fabrice Gasnier <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

>
> Thanks,
> Fabrice
>
> > drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> > index 0a4d374..26e2011 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-core.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> > @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> > }
> > priv->dfsdm.phys_base = res->start;
> > priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
> > + if (IS_ERR(priv->dfsdm.base))
> > + return PTR_ERR(priv->dfsdm.base);
> >
> > /*
> > * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
> > @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> > */
> > priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
> > if (IS_ERR(priv->clk)) {
> > - dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
> > - return -EINVAL;
> > + ret = PTR_ERR(priv->clk);
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
> > + return ret;
> > }
> >
> > priv->aclk = devm_clk_get(&pdev->dev, "audio");
> >