2019-05-02 19:50:00

by Raul Rangel

[permalink] [raw]
Subject: [PATCH] block: Fix function name in comment

The comment was out of date.

Signed-off-by: Raul E Rangel <[email protected]>
---

block/blk-mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 9516304a38ee..0e467ff440a2 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
list_del_init(&page->lru);
/*
* Remove kmemleak object previously allocated in
- * blk_mq_init_rq_map().
+ * blk_mq_alloc_rqs().
*/
kmemleak_free(page_address(page));
__free_pages(page, page->private);
--
2.21.0.593.g511ec345e18-goog


2019-05-02 20:34:55

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] block: Fix function name in comment

On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
+AD4 The comment was out of date.
+AD4
+AD4 Signed-off-by: Raul E Rangel +ADw-rrangel+AEA-chromium.org+AD4
+AD4 ---
+AD4
+AD4 block/blk-mq.c +AHw 2 +-
+AD4 1 file changed, 1 insertion(), 1 deletion(-)
+AD4
+AD4 diff --git a/block/blk-mq.c b/block/blk-mq.c
+AD4 index 9516304a38ee..0e467ff440a2 100644
+AD4 --- a/block/blk-mq.c
+AD4 diff --git a/block/blk-mq.c b/block/blk-mq.c
+AD4 index 9516304a38ee..0e467ff440a2 100644
+AD4 --- a/block/blk-mq.c
+AD4 +-+-+- b/block/blk-mq.c
+AD4 +AEAAQA -2062,7 +-2062,7 +AEAAQA void blk+AF8-mq+AF8-free+AF8-rqs(struct blk+AF8-mq+AF8-tag+AF8-set +ACo-set, struct blk+AF8-mq+AF8-tags +ACo-tags,
+AD4 list+AF8-del+AF8-init(+ACY-page-+AD4-lru)+ADs
+AD4 /+ACo
+AD4 +ACo Remove kmemleak object previously allocated in
+AD4 - +ACo blk+AF8-mq+AF8-init+AF8-rq+AF8-map().
+AD4 +- +ACo blk+AF8-mq+AF8-alloc+AF8-rqs().
+AD4 +ACo-/
+AD4 kmemleak+AF8-free(page+AF8-address(page))+ADs
+AD4 +AF8AXw-free+AF8-pages(page, page-+AD4-private)+ADs

Does the entire comment fit on a single 80 column line? In other words, can
the comment that is spread over four lines be reduced to a single line?

Thanks,

Bart.

2019-05-02 20:52:31

by Raul Rangel

[permalink] [raw]
Subject: Re: [PATCH] block: Fix function name in comment

On Thu, May 02, 2019 at 01:33:45PM -0700, Bart Van Assche wrote:
> On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
> > The comment was out of date.
> >
> > Signed-off-by: Raul E Rangel <[email protected]>
> > ---
> >
> > block/blk-mq.c | 2 +
> > 1 file changed, 1 insertion(), 1 deletion(-)
> >
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 9516304a38ee..0e467ff440a2 100644
> > --- a/block/blk-mq.c
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 9516304a38ee..0e467ff440a2 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
> > list_del_init(&page->lru);
> > /*
> > * Remove kmemleak object previously allocated in
> > - * blk_mq_init_rq_map().
> > + * blk_mq_alloc_rqs().
> > */
> > kmemleak_free(page_address(page));
> > __free_pages(page, page->private);
>
> Does the entire comment fit on a single 80 column line? In other words, can
> the comment that is spread over four lines be reduced to a single line?
No, it would put it at 91 characters long.

Raul
>
> Thanks,
>
> Bart.

2019-05-02 20:58:19

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] block: Fix function name in comment

On Thu, 2019-05-02 at 14:51 -0600, Raul Rangel wrote:
+AD4 On Thu, May 02, 2019 at 01:33:45PM -0700, Bart Van Assche wrote:
+AD4 +AD4 On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
+AD4 +AD4 +AD4 The comment was out of date.
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 Signed-off-by: Raul E Rangel +ADw-rrangel+AEA-chromium.org+AD4
+AD4 +AD4 +AD4 ---
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 block/blk-mq.c +AHw 2 +-
+AD4 +AD4 +AD4 1 file changed, 1 insertion(), 1 deletion(-)
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 diff --git a/block/blk-mq.c b/block/blk-mq.c
+AD4 +AD4 +AD4 index 9516304a38ee..0e467ff440a2 100644
+AD4 +AD4 +AD4 --- a/block/blk-mq.c
+AD4 +AD4 +AD4 diff --git a/block/blk-mq.c b/block/blk-mq.c
+AD4 +AD4 +AD4 index 9516304a38ee..0e467ff440a2 100644
+AD4 +AD4 +AD4 --- a/block/blk-mq.c
+AD4 +AD4 +AD4 +-+-+- b/block/blk-mq.c
+AD4 +AD4 +AD4 +AEAAQA -2062,7 +-2062,7 +AEAAQA void blk+AF8-mq+AF8-free+AF8-rqs(struct blk+AF8-mq+AF8-tag+AF8-set +ACo-set, struct blk+AF8-mq+AF8-tags +ACo-tags,
+AD4 +AD4 +AD4 list+AF8-del+AF8-init(+ACY-page-+AD4-lru)+ADs
+AD4 +AD4 +AD4 /+ACo
+AD4 +AD4 +AD4 +ACo Remove kmemleak object previously allocated in
+AD4 +AD4 +AD4 - +ACo blk+AF8-mq+AF8-init+AF8-rq+AF8-map().
+AD4 +AD4 +AD4 +- +ACo blk+AF8-mq+AF8-alloc+AF8-rqs().
+AD4 +AD4 +AD4 +ACo-/
+AD4 +AD4 +AD4 kmemleak+AF8-free(page+AF8-address(page))+ADs
+AD4 +AD4 +AD4 +AF8AXw-free+AF8-pages(page, page-+AD4-private)+ADs
+AD4 +AD4
+AD4 +AD4 Does the entire comment fit on a single 80 column line? In other words, can
+AD4 +AD4 the comment that is spread over four lines be reduced to a single line?
+AD4
+AD4 No, it would put it at 91 characters long.

That's unfortunate ...

2019-05-02 21:00:44

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] block: Fix function name in comment

On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
+AD4 The comment was out of date.

Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4


2019-05-02 21:55:44

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] block: Fix function name in comment

On 5/2/19 1:48 PM, Raul E Rangel wrote:
> The comment was out of date.

Applied, thanks.

--
Jens Axboe