2019-05-31 10:35:27

by Colin King

Subject: [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr

From: Colin Ian King <[email protected]>

The assignment of err is using the incorrect pointer vaddr that has
not been initialized. Fix this by using the correct pointer obj instead.

Addresses-Coverity: ("Uninitialized pointer read")
Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 8de568d2c792..e23d8c9e9298 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -32,7 +32,7 @@ static int igt_fill_blt(void *arg)

obj = i915_gem_object_create_internal(i915, sz);
if (IS_ERR(obj)) {
- err = PTR_ERR(vaddr);
+ err = PTR_ERR(obj);
goto err_flush;
}

--
2.20.1

2019-05-31 10:42:05

by Chris Wilson

Subject: Re: [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr

Quoting Colin King (2019-05-31 11:32:01)
> From: Colin Ian King <[email protected]>
>
> The assignment of err is using the incorrect pointer vaddr that has
> not been initialized. Fix this by using the correct pointer obj instead.
>
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed and pushed, thanks for the fix!
-Chris