Hi:
I am recently reading the LPM related code in xhci driver, and I find
that the xhci->sw_lpm_support is not really used, but I am not sure
whether we should remove it or not?
Any ideas, Thanks.
Regards
Zengtao
On 15.10.2018 12:35, Zengtao (B) wrote:
> Hi:
>
> I am recently reading the LPM related code in xhci driver, and I find
> that the xhci->sw_lpm_support is not really used, but I am not sure
> whether we should remove it or not?
>
> Any ideas, Thanks.
I think it was used to prevent LPM in pre-0.96 xHC controllers.
Now driver only supports HW LPM for 1.0 and later controllers, so xhci->sw_lpm_support
doesn't really do anything.
You can send a patch removing it
Thanks
-Mathias
Hi Mathias:
>-----Original Message-----
>From: Mathias Nyman [mailto:[email protected]]
>Sent: Monday, October 15, 2018 8:11 PM
>To: Zengtao (B) <[email protected]>; Greg KH
><[email protected]>
>Cc: [email protected]; [email protected]
>Subject: Re: Can we just remove the sw_lpm_support from current xhci
>driver?
>
>On 15.10.2018 12:35, Zengtao (B) wrote:
>> Hi:
>>
>> I am recently reading the LPM related code in xhci driver, and I find
>> that the xhci->sw_lpm_support is not really used, but I am not sure
>> whether we should remove it or not?
>>
>> Any ideas, Thanks.
>
>I think it was used to prevent LPM in pre-0.96 xHC controllers.
>Now driver only supports HW LPM for 1.0 and later controllers, so
>xhci->sw_lpm_support doesn't really do anything.
>
>You can send a patch removing it
>
Ok, I will send a patch to do it, thanks.
>Thanks
>-Mathias