2019-08-08 23:48:01

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v8 02/21] pinctrl: tegra: Add write barrier after all pinctrl register writes

This patch adds write barrier after all pinctrl register writes
during resume to make sure all pinctrl changes are complete.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/pinctrl/tegra/pinctrl-tegra.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 982ee634b3b1..f49fe29fb6df 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -677,6 +677,8 @@ static int tegra_pinctrl_resume(struct device *dev)
writel_relaxed(*backup_regs++, regs++);
}

+ /* make sure all the pinmux register writes are complete */
+ wmb();
return 0;
}

--
2.7.4


2019-08-09 11:40:47

by Dmitry Osipenko

[permalink] [raw]
Subject: Re: [PATCH v8 02/21] pinctrl: tegra: Add write barrier after all pinctrl register writes

09.08.2019 2:46, Sowjanya Komatineni пишет:
> This patch adds write barrier after all pinctrl register writes
> during resume to make sure all pinctrl changes are complete.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 982ee634b3b1..f49fe29fb6df 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -677,6 +677,8 @@ static int tegra_pinctrl_resume(struct device *dev)
> writel_relaxed(*backup_regs++, regs++);
> }
>
> + /* make sure all the pinmux register writes are complete */
> + wmb();
> return 0;
> }
>
>

Reviewed-by: Dmitry Osipenko <[email protected]>

2019-08-12 09:21:59

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v8 02/21] pinctrl: tegra: Add write barrier after all pinctrl register writes

On Thu, Aug 08, 2019 at 04:46:41PM -0700, Sowjanya Komatineni wrote:
> This patch adds write barrier after all pinctrl register writes
> during resume to make sure all pinctrl changes are complete.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 2 ++
> 1 file changed, 2 insertions(+)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (409.00 B)
 signature.asc (849.00 B)
 Download all attachments

2019-08-14 08:34:57

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v8 02/21] pinctrl: tegra: Add write barrier after all pinctrl register writes

On Fri, Aug 9, 2019 at 1:47 AM Sowjanya Komatineni
<[email protected]> wrote:

> This patch adds write barrier after all pinctrl register writes
> during resume to make sure all pinctrl changes are complete.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>

Patch applied with the ACKs.

Yours,
Linus Walleij