2019-09-02 12:44:24

by Souptick Joarder

Subject: [PATCH] video/fbdev/68328fb: Remove dead code

This is dead code since 3.15. If their is no plan to
use it further, these can be removed forever.

Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/video/fbdev/68328fb.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c
index d48e960..02d22b7 100644
--- a/drivers/video/fbdev/68328fb.c
+++ b/drivers/video/fbdev/68328fb.c
@@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)

int __init mc68x328fb_setup(char *options)
{
-#if 0
- char *this_opt;
-#endif
-
if (!options || !*options)
return 1;
-#if 0
- while ((this_opt = strsep(&options, ",")) != NULL) {
- if (!*this_opt)
- continue;
- if (!strncmp(this_opt, "disable", 7))
- mc68x328fb_enable = 0;
- }
-#endif
return 1;
}

--
1.9.1

2020-01-03 12:13:53

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH] video/fbdev/68328fb: Remove dead code

On 9/2/19 2:49 PM, Souptick Joarder wrote:
> This is dead code since 3.15. If their is no plan to
> use it further, these can be removed forever.
>
> Signed-off-by: Souptick Joarder <[email protected]>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/video/fbdev/68328fb.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c
> index d48e960..02d22b7 100644
> --- a/drivers/video/fbdev/68328fb.c
> +++ b/drivers/video/fbdev/68328fb.c
> @@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
>
> int __init mc68x328fb_setup(char *options)
> {
> -#if 0
> - char *this_opt;
> -#endif
> -
> if (!options || !*options)
> return 1;
> -#if 0
> - while ((this_opt = strsep(&options, ",")) != NULL) {
> - if (!*this_opt)
> - continue;
> - if (!strncmp(this_opt, "disable", 7))
> - mc68x328fb_enable = 0;
> - }
> -#endif
> return 1;
> }
>