2021-04-07 22:44:59

by Guru Das Srinagesh

Subject: [PATCH 1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm8008 support

Add support for the PM8008 GPIO support to the Qualcomm PMIC GPIO
binding.

Signed-off-by: Guru Das Srinagesh <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index 70e119b..1818481 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -36,6 +36,7 @@ PMIC's from Qualcomm.
"qcom,pm6150-gpio"
"qcom,pm6150l-gpio"
"qcom,pmx55-gpio"
+ "qcom,pm8008-gpio"

And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
if the device is on an spmi bus or an ssbi bus respectively
@@ -125,6 +126,7 @@ to specify in a pin configuration subnode:
gpio1-gpio12 for pm6150l
gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
and gpio11)
+ gpio1-gpio2 for pm8008

- function:
Usage: required
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-04-08 03:39:15

by Bjorn Andersson

Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm8008 support

On Wed 07 Apr 17:34 CDT 2021, Guru Das Srinagesh wrote:

> Add support for the PM8008 GPIO support to the Qualcomm PMIC GPIO
> binding.
>
> Signed-off-by: Guru Das Srinagesh <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index 70e119b..1818481 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -36,6 +36,7 @@ PMIC's from Qualcomm.
> "qcom,pm6150-gpio"
> "qcom,pm6150l-gpio"
> "qcom,pmx55-gpio"
> + "qcom,pm8008-gpio"

Please keep these sorted alphabetically (i.e. '8' < 'x')

With that

Acked-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

>
> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> if the device is on an spmi bus or an ssbi bus respectively
> @@ -125,6 +126,7 @@ to specify in a pin configuration subnode:
> gpio1-gpio12 for pm6150l
> gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
> and gpio11)
> + gpio1-gpio2 for pm8008
>
> - function:
> Usage: required
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>