2019-09-11 12:46:42

by tiantao (H)

Subject: [PATCH] PCI: vc: fix warning: no previous prototype

From: tiantao <[email protected]>

drivers/pci/vc.c:351:5: warning: no previous prototype for
pci_save_vc_state [-Wmissing-prototypes]
int pci_save_vc_state(struct pci_dev *dev)

drivers/pci/vc.c:388:6: warning: no previous prototype for
pci_restore_vc_state [-Wmissing-prototypes]
void pci_restore_vc_state(struct pci_dev *dev)

drivers/pci/vc.c:412:6: warning: no previous prototype for
pci_allocate_vc_save_buffers [-Wmissing-prototypes]
void pci_allocate_vc_save_buffers(struct pci_dev *dev)

Signed-off-by: Tian Tao <[email protected]>
---
drivers/pci/vc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
index b39e854..111f6d3 100644
--- a/drivers/pci/vc.c
+++ b/drivers/pci/vc.c
@@ -12,6 +12,7 @@
#include <linux/pci.h>
#include <linux/pci_regs.h>
#include <linux/types.h>
+#include "pci.h"

/**
* pci_vc_save_restore_dwords - Save or restore a series of dwords
--
2.7.4

2019-09-27 13:01:38

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: vc: fix warning: no previous prototype

On Wed, Sep 11, 2019 at 08:40:51PM +0800, tiantao6 wrote:
> From: tiantao <[email protected]>
>
> drivers/pci/vc.c:351:5: warning: no previous prototype for
> pci_save_vc_state [-Wmissing-prototypes]
> int pci_save_vc_state(struct pci_dev *dev)
>
> drivers/pci/vc.c:388:6: warning: no previous prototype for
> pci_restore_vc_state [-Wmissing-prototypes]
> void pci_restore_vc_state(struct pci_dev *dev)
>
> drivers/pci/vc.c:412:6: warning: no previous prototype for
> pci_allocate_vc_save_buffers [-Wmissing-prototypes]
> void pci_allocate_vc_save_buffers(struct pci_dev *dev)
>
> Signed-off-by: Tian Tao <[email protected]>

Thanks, this was fixed incidentally by ca78410403dd ("PCI: Get rid of
dev->has_secondary_link flag").

> ---
> drivers/pci/vc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
> index b39e854..111f6d3 100644
> --- a/drivers/pci/vc.c
> +++ b/drivers/pci/vc.c
> @@ -12,6 +12,7 @@
> #include <linux/pci.h>
> #include <linux/pci_regs.h>
> #include <linux/types.h>
> +#include "pci.h"
>
> /**
> * pci_vc_save_restore_dwords - Save or restore a series of dwords
> --
> 2.7.4
>