2019-10-21 10:19:45

by Radhey Shyam Pandey

Subject: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as supported platform

xilinx axi_emac driver is supported on ZynqMP UltraScale platform.
So enable ARCH64 in kconfig. It also removes redundant ARCH_ZYNQ
dependency. Basic sanity testing is done on zu+ mpsoc zcu102
evaluation board.

Signed-off-by: Radhey Shyam Pandey <[email protected]>
---
Changes for v2:
Remove redundant ARCH_ZYNQ dependency.
Modified commit description.
---
drivers/net/ethernet/xilinx/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 8d994ce..da11876 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -6,7 +6,7 @@
config NET_VENDOR_XILINX
bool "Xilinx devices"
default y
- depends on PPC || PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS || X86 || ARM || COMPILE_TEST
+ depends on PPC || PPC32 || MICROBLAZE || MIPS || X86 || ARM || ARM64 || COMPILE_TEST
---help---
If you have a network (Ethernet) card belonging to this class, say Y.

@@ -26,11 +26,11 @@ config XILINX_EMACLITE

config XILINX_AXI_EMAC
tristate "Xilinx 10/100/1000 AXI Ethernet support"
- depends on MICROBLAZE || X86 || ARM || COMPILE_TEST
+ depends on MICROBLAZE || X86 || ARM || ARM64 || COMPILE_TEST
select PHYLINK
---help---
This driver supports the 10/100/1000 Ethernet from Xilinx for the
- AXI bus interface used in Xilinx Virtex FPGAs.
+ AXI bus interface used in Xilinx Virtex FPGAs and Soc's.

config XILINX_LL_TEMAC
tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
--
2.7.4

2019-10-21 14:16:33

by Michal Simek

Subject: Re: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as supported platform

On 21. 10. 19 12:18, Radhey Shyam Pandey wrote:
> xilinx axi_emac driver is supported on ZynqMP UltraScale platform.
> So enable ARCH64 in kconfig. It also removes redundant ARCH_ZYNQ
> dependency. Basic sanity testing is done on zu+ mpsoc zcu102
> evaluation board.
>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> ---
> Changes for v2:
> Remove redundant ARCH_ZYNQ dependency.
> Modified commit description.
> ---
> drivers/net/ethernet/xilinx/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> index 8d994ce..da11876 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -6,7 +6,7 @@
> config NET_VENDOR_XILINX
> bool "Xilinx devices"
> default y
> - depends on PPC || PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS || X86 || ARM || COMPILE_TEST
> + depends on PPC || PPC32 || MICROBLAZE || MIPS || X86 || ARM || ARM64 || COMPILE_TEST
> ---help---
> If you have a network (Ethernet) card belonging to this class, say Y.
>
> @@ -26,11 +26,11 @@ config XILINX_EMACLITE
>
> config XILINX_AXI_EMAC
> tristate "Xilinx 10/100/1000 AXI Ethernet support"
> - depends on MICROBLAZE || X86 || ARM || COMPILE_TEST
> + depends on MICROBLAZE || X86 || ARM || ARM64 || COMPILE_TEST
> select PHYLINK
> ---help---
> This driver supports the 10/100/1000 Ethernet from Xilinx for the
> - AXI bus interface used in Xilinx Virtex FPGAs.
> + AXI bus interface used in Xilinx Virtex FPGAs and Soc's.
>
> config XILINX_LL_TEMAC
> tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
>

Acked-by: Michal Simek <[email protected]>

But I can image that others could prefer to remove all dependencies.

Thanks,
Michal

2019-10-22 22:00:55

by Jakub Kicinski

Subject: Re: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as supported platform

On Mon, 21 Oct 2019 16:15:45 +0200, Michal Simek wrote:
> On 21. 10. 19 12:18, Radhey Shyam Pandey wrote:
> > xilinx axi_emac driver is supported on ZynqMP UltraScale platform.
> > So enable ARCH64 in kconfig. It also removes redundant ARCH_ZYNQ
> > dependency. Basic sanity testing is done on zu+ mpsoc zcu102
> > evaluation board.
> >
> > Signed-off-by: Radhey Shyam Pandey <[email protected]>
> > ---
> > Changes for v2:
> > Remove redundant ARCH_ZYNQ dependency.
> > Modified commit description.
> > ---
> > drivers/net/ethernet/xilinx/Kconfig | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> > index 8d994ce..da11876 100644
> > --- a/drivers/net/ethernet/xilinx/Kconfig
> > +++ b/drivers/net/ethernet/xilinx/Kconfig
> > @@ -6,7 +6,7 @@
> > config NET_VENDOR_XILINX
> > bool "Xilinx devices"
> > default y
> > - depends on PPC || PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS || X86 || ARM || COMPILE_TEST
> > + depends on PPC || PPC32 || MICROBLAZE || MIPS || X86 || ARM || ARM64 || COMPILE_TEST
> > ---help---
> > If you have a network (Ethernet) card belonging to this class, say Y.
> >
> > @@ -26,11 +26,11 @@ config XILINX_EMACLITE
> >
> > config XILINX_AXI_EMAC
> > tristate "Xilinx 10/100/1000 AXI Ethernet support"
> > - depends on MICROBLAZE || X86 || ARM || COMPILE_TEST
> > + depends on MICROBLAZE || X86 || ARM || ARM64 || COMPILE_TEST
> > select PHYLINK
> > ---help---
> > This driver supports the 10/100/1000 Ethernet from Xilinx for the
> > - AXI bus interface used in Xilinx Virtex FPGAs.
> > + AXI bus interface used in Xilinx Virtex FPGAs and Soc's.
> >
> > config XILINX_LL_TEMAC
> > tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
> >
>
> Acked-by: Michal Simek <[email protected]>
>
> But I can image that others could prefer to remove all dependencies.

Yes, we'd much rather see this litany of architectures removed.
Is there any reason it's there in the first place?

Most drivers are tested on just a few architectures, but as long
as correct APIs are used they are assumed to work across the board.
Otherwise 75% of our drivers would be x86 only. Don't be shy.

2019-10-24 13:07:55

by Radhey Shyam Pandey

Subject: RE: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as supported platform

> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Tuesday, October 22, 2019 11:00 PM
> To: Michal Simek <[email protected]>
> Cc: Radhey Shyam Pandey <[email protected]>; [email protected];
> [email protected]; Anirudha Sarangi <[email protected]>; John Linn
> <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]
> Subject: Re: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as
> supported platform
>
> On Mon, 21 Oct 2019 16:15:45 +0200, Michal Simek wrote:
> > On 21. 10. 19 12:18, Radhey Shyam Pandey wrote:
> > > xilinx axi_emac driver is supported on ZynqMP UltraScale platform.
> > > So enable ARCH64 in kconfig. It also removes redundant ARCH_ZYNQ
> > > dependency. Basic sanity testing is done on zu+ mpsoc zcu102
> > > evaluation board.
> > >
> > > Signed-off-by: Radhey Shyam Pandey
> <[email protected]>
> > > ---
> > > Changes for v2:
> > > Remove redundant ARCH_ZYNQ dependency.
> > > Modified commit description.
> > > ---
> > > drivers/net/ethernet/xilinx/Kconfig | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/xilinx/Kconfig
> b/drivers/net/ethernet/xilinx/Kconfig
> > > index 8d994ce..da11876 100644
> > > --- a/drivers/net/ethernet/xilinx/Kconfig
> > > +++ b/drivers/net/ethernet/xilinx/Kconfig
> > > @@ -6,7 +6,7 @@
> > > config NET_VENDOR_XILINX
> > > bool "Xilinx devices"
> > > default y
> > > - depends on PPC || PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS ||
> X86 || ARM || COMPILE_TEST
> > > + depends on PPC || PPC32 || MICROBLAZE || MIPS || X86 || ARM ||
> ARM64 || COMPILE_TEST
> > > ---help---
> > > If you have a network (Ethernet) card belonging to this class, say Y.
> > >
> > > @@ -26,11 +26,11 @@ config XILINX_EMACLITE
> > >
> > > config XILINX_AXI_EMAC
> > > tristate "Xilinx 10/100/1000 AXI Ethernet support"
> > > - depends on MICROBLAZE || X86 || ARM || COMPILE_TEST
> > > + depends on MICROBLAZE || X86 || ARM || ARM64 || COMPILE_TEST
> > > select PHYLINK
> > > ---help---
> > > This driver supports the 10/100/1000 Ethernet from Xilinx for the
> > > - AXI bus interface used in Xilinx Virtex FPGAs.
> > > + AXI bus interface used in Xilinx Virtex FPGAs and Soc's.
> > >
> > > config XILINX_LL_TEMAC
> > > tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
> > >
> >
> > Acked-by: Michal Simek <[email protected]>
> >
> > But I can image that others could prefer to remove all dependencies.
>
> Yes, we'd much rather see this litany of architectures removed.

Yes, I can build test on all mentioned architectures and see how it goes.

> Is there any reason it's there in the first place?
Looking into past few commits, this dependency list was incrementally
extended for each platform. In case there are no real dependencies
we can get rid of arch list.

>
> Most drivers are tested on just a few architectures, but as long
> as correct APIs are used they are assumed to work across the board.
> Otherwise 75% of our drivers would be x86 only. Don't be shy.