2019-11-26 17:12:32

by Zhou Yanjie

[permalink] [raw]
Subject: Add initial support for Ingenic X1000 SoC and Y&A CU Neo board v4.

1.Adjust the description in "devices.yaml" to make it more reasonable.
2.Adjust "model" in "cu1000.dts" to match the description in "devices.yaml".
3.Adjust "bool" in "Kconfig" to avoid duplicate names with subsequent boards.
4.Add pdma controller DT node and Update defconfig for pdma controller.



2019-11-26 17:13:21

by Zhou Yanjie

[permalink] [raw]
Subject: [PATCH v4 6/6] MIPS: CU1000: Update defconfig for pdma controller.

Selected pdma controller support by default.

Signed-off-by: Zhou Yanjie <[email protected]>
---

Notes:
v4:
New patch.

arch/mips/configs/cu1000_defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/mips/configs/cu1000_defconfig b/arch/mips/configs/cu1000_defconfig
index 88729ee..9f26d00 100644
--- a/arch/mips/configs/cu1000_defconfig
+++ b/arch/mips/configs/cu1000_defconfig
@@ -62,6 +62,8 @@ CONFIG_GPIO_SYSFS=y
# CONFIG_VGA_CONSOLE is not set
# CONFIG_HID is not set
# CONFIG_USB_SUPPORT is not set
+CONFIG_DMADEVICES=y
+CONFIG_DMA_JZ4780=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_NVMEM=y
CONFIG_NVMEM_SYSFS=y
--
2.7.4


2019-11-26 17:13:23

by Zhou Yanjie

[permalink] [raw]
Subject: [PATCH v4 3/6] dt-bindings: MIPS: Add Ingenic XBurst based boards.

Add Ingenic XBurst based boards, prepare for later dts.

Signed-off-by: Zhou Yanjie <[email protected]>
---

Notes:
v1->v2:
No change.

v2->v3:
No change.

v3->v4:
Adjust the description to make it more reasonable.

.../devicetree/bindings/mips/ingenic/devices.yaml | 35 ++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mips/ingenic/devices.yaml

diff --git a/Documentation/devicetree/bindings/mips/ingenic/devices.yaml b/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
new file mode 100644
index 00000000..a6f5056
--- /dev/null
+++ b/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mips/ingenic/devices.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ingenic XBurst based Platforms Device Tree Bindings
+
+maintainers:
+ - Zhou Yanjie <[email protected]>
+description: |
+ Devices with a Ingenic XBurst CPU shall have the following properties.
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+
+ - description: Qi Hardware Ben NanoNote
+ items:
+ - const: qi,lb60
+
+ - description: Game Consoles Worldwide GCW Zero
+ items:
+ - const: gcw,zero
+
+ - description: MIPS Creator CI20
+ items:
+ - const: img,ci20
+
+ - description: YSH & ATIL General Board CU Neo
+ items:
+ - const: yna,cu1000
+...
--
2.7.4


2019-11-26 17:14:33

by Zhou Yanjie

[permalink] [raw]
Subject: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.

Add the appropriate DT node to probe the pdma controller driver
using the devicetree.

Signed-off-by: Zhou Yanjie <[email protected]>
---

Notes:
v4:
New patch.

arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
index 9e55edd..edfa70d 100644
--- a/arch/mips/boot/dts/ingenic/x1000.dtsi
+++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#include <dt-bindings/clock/x1000-cgu.h>
+#include <dt-bindings/dma/x1000-dma.h>

/ {
#address-cells = <1>;
@@ -173,4 +174,16 @@

status = "disabled";
};
+
+ pdma: dma-controller@13420000 {
+ compatible = "ingenic,x1000-dma";
+ reg = <0x13420000 0x400
+ 0x13421000 0x40>;
+ #dma-cells = <2>;
+
+ interrupt-parent = <&intc>;
+ interrupts = <10>;
+
+ clocks = <&cgu X1000_CLK_PDMA>;
+ };
};
--
2.7.4


2019-11-27 16:52:27

by Paul Cercueil

[permalink] [raw]
Subject: Re: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.

Hi Zhou,


Le mer., nov. 27, 2019 at 01:06, Zhou Yanjie <[email protected]> a
?crit :
> Add the appropriate DT node to probe the pdma controller driver
> using the devicetree.
>
> Signed-off-by: Zhou Yanjie <[email protected]>
> ---
>
> Notes:
> v4:
> New patch.
>
> arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi
> b/arch/mips/boot/dts/ingenic/x1000.dtsi
> index 9e55edd..edfa70d 100644
> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <dt-bindings/clock/x1000-cgu.h>
> +#include <dt-bindings/dma/x1000-dma.h>

You're not using any macro from that include file, so there's no need
to have it here.

Cheers,
-Paul


>
> / {
> #address-cells = <1>;
> @@ -173,4 +174,16 @@
>
> status = "disabled";
> };
> +
> + pdma: dma-controller@13420000 {
> + compatible = "ingenic,x1000-dma";
> + reg = <0x13420000 0x400
> + 0x13421000 0x40>;
> + #dma-cells = <2>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <10>;
> +
> + clocks = <&cgu X1000_CLK_PDMA>;
> + };
> };
> --
> 2.7.4
>
>


2019-11-28 03:30:34

by Zhou Yanjie

[permalink] [raw]
Subject: Re: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.

Hi Paul,

On 2019年11月28日 00:48, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., nov. 27, 2019 at 01:06, Zhou Yanjie <[email protected]> a
> écrit :
>> Add the appropriate DT node to probe the pdma controller driver
>> using the devicetree.
>>
>> Signed-off-by: Zhou Yanjie <[email protected]>
>> ---
>>
>> Notes:
>> v4:
>> New patch.
>>
>> arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi
>> b/arch/mips/boot/dts/ingenic/x1000.dtsi
>> index 9e55edd..edfa70d 100644
>> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>> @@ -1,5 +1,6 @@
>> // SPDX-License-Identifier: GPL-2.0
>> #include <dt-bindings/clock/x1000-cgu.h>
>> +#include <dt-bindings/dma/x1000-dma.h>
>
> You're not using any macro from that include file, so there's no need
> to have it here.
>

Sure, I will fix this in v7.

Thanks and best regards!

> Cheers,
> -Paul
>
>
>>
>> / {
>> #address-cells = <1>;
>> @@ -173,4 +174,16 @@
>>
>> status = "disabled";
>> };
>> +
>> + pdma: dma-controller@13420000 {
>> + compatible = "ingenic,x1000-dma";
>> + reg = <0x13420000 0x400
>> + 0x13421000 0x40>;
>> + #dma-cells = <2>;
>> +
>> + interrupt-parent = <&intc>;
>> + interrupts = <10>;
>> +
>> + clocks = <&cgu X1000_CLK_PDMA>;
>> + };
>> };
>> --
>> 2.7.4
>>
>>
>
>