2020-01-17 04:09:12

by Mimi Zohar

[permalink] [raw]
Subject: Re: [PATCH v2] IMA: pre-allocate buffer to hold keyrings string

On Thu, 2020-01-16 at 18:18 -0800, Lakshmi Ramasubramanian wrote:
> ima_match_keyring() is called while holding rcu read lock. Since this
> function executes in atomic context, it should not call any function
> that can sleep (such as kstrdup()).
>
> This patch pre-allocates a buffer to hold the keyrings string read from
> the IMA policy and uses that to match the given keyring.
>
> Signed-off-by: Lakshmi Ramasubramanian <[email protected]>
> Fixes: e9085e0ad38a ("IMA: Add support to limit measuring keys")

Thanks!  This patch is now queued in next-integrity-testing.

Mimi