2020-03-05 06:50:03

by Tony W Wang-oc

Subject: [PATCH v1 0/2] x86/Kconfig: modify X86_UMIP depends on CPUs

CONFIG_X86_UMIP is generic since commit b971880fe79f (x86/Kconfig:
Rename UMIP config parameter).

Some Centaur family 7 CPUs and Zhaoxin family 7 CPUs support the UMIP
feature. So, modify X86_UMIP to cover these CPUs too.

Tony W Wang-oc (2):
x86/Kconfig: Make X86_UMIP to cover Centaur CPUs
x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs

arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4

2020-03-05 06:50:42

by Tony W Wang-oc

Subject: [PATCH v1 2/2] x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs

Zhaoxin family 7 CPUs support the UMIP (User-Mode Instruction
Prevention) feature. So modify config X86_UMIP depends on Zhaoxin
CPUs too.

Signed-off-by: Tony W Wang-oc <[email protected]>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 710f932..ce2054d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1871,7 +1871,7 @@ config X86_SMAP

config X86_UMIP
def_bool y
- depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR
+ depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR || CPU_SUP_ZHAOXIN
prompt "User Mode Instruction Prevention" if EXPERT
---help---
User Mode Instruction Prevention (UMIP) is a security feature in
--
2.7.4

2020-03-05 06:50:54

by Tony W Wang-oc

Subject: [PATCH v1 1/2] x86/Kconfig: Make X86_UMIP to cover Centaur CPUs

Some Centaur family 7 CPUs support the UMIP (User-Mode Instruction
Prevention) feature. So modify config X86_UMIP depends on Centaur
CPUs too.

Signed-off-by: Tony W Wang-oc <[email protected]>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5ad3957..710f932 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1871,7 +1871,7 @@ config X86_SMAP

config X86_UMIP
def_bool y
- depends on CPU_SUP_INTEL || CPU_SUP_AMD
+ depends on CPU_SUP_INTEL || CPU_SUP_AMD || CPU_SUP_CENTAUR
prompt "User Mode Instruction Prevention" if EXPERT
---help---
User Mode Instruction Prevention (UMIP) is a security feature in
--
2.7.4

2020-03-05 15:51:57

by Sean Christopherson

Subject: Re: [PATCH v1 0/2] x86/Kconfig: modify X86_UMIP depends on CPUs

On Thu, Mar 05, 2020 at 02:49:09PM +0800, Tony W Wang-oc wrote:
> CONFIG_X86_UMIP is generic since commit b971880fe79f (x86/Kconfig:
> Rename UMIP config parameter).
>
> Some Centaur family 7 CPUs and Zhaoxin family 7 CPUs support the UMIP
> feature. So, modify X86_UMIP to cover these CPUs too.

That leaves UMC_32, TRANSMETA_32 and CYRIX_32 as the last CPU_SUP types
that don't support UMIP. Maybe it's time to remove the CPU_SUP checks
altogether, same as X86_SMAP?

> Tony W Wang-oc (2):
> x86/Kconfig: Make X86_UMIP to cover Centaur CPUs
> x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs
>
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.7.4
>

2020-03-06 09:15:01

by Tony W Wang-oc

Subject: Re: [PATCH v1 0/2] x86/Kconfig: modify X86_UMIP depends on CPUs

On 05/03/2020 23:51, Sean Christopherson wrote:
> On Thu, Mar 05, 2020 at 02:49:09PM +0800, Tony W Wang-oc wrote:
>> CONFIG_X86_UMIP is generic since commit b971880fe79f (x86/Kconfig:
>> Rename UMIP config parameter).
>>
>> Some Centaur family 7 CPUs and Zhaoxin family 7 CPUs support the UMIP
>> feature. So, modify X86_UMIP to cover these CPUs too.
>
> That leaves UMC_32, TRANSMETA_32 and CYRIX_32 as the last CPU_SUP types
> that don't support UMIP. Maybe it's time to remove the CPU_SUP checks
> altogether, same as X86_SMAP?

While the UMIP is a generic X86 CPU feature, I think this way is better.

Sincerely
TonyWWang-oc
>
>> Tony W Wang-oc (2):
>> x86/Kconfig: Make X86_UMIP to cover Centaur CPUs
>> x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs
>>
>> arch/x86/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --
>> 2.7.4
>>
> .
>