2020-03-28 01:05:51

by Rishabh Bhatnagar

Subject: [PATCH] dt-bindings: remoteproc: Add interconnect property

Allow proxy voting/unvoting of bus bandwidth for remote
processors. This property will specify the bus-master and
slave so that remoteproc platform driver can make the proxy
vote for bus bandwidth.

Signed-off-by: Rishabh Bhatnagar <[email protected]>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
index 9938918..529b0a0 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
@@ -111,6 +111,17 @@ on the Qualcomm ADSP Hexagon core.
qcom,sm8150-slpi-pas:
must be "lcx", "lmx", "load_state"

+- interconnect:
+ Usage: optional
+ Value type: <prop-encoded-array>
+ Definition: Specifies the interconnect bus-master and bus-slave for
+ bandwidth voting during proxy vote/unvote.
+
+- interconnect-names:
+ Usage: optional
+ Value type: <stringlist>
+ Definition: The interconnect name depends on the compatible string
+
- memory-region:
Usage: required
Value type: <phandle>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-03-31 23:42:40

by Bjorn Andersson

Subject: Re: [PATCH] dt-bindings: remoteproc: Add interconnect property

On Fri 27 Mar 18:04 PDT 2020, Rishabh Bhatnagar wrote:

> Allow proxy voting/unvoting of bus bandwidth for remote
> processors. This property will specify the bus-master and
> slave so that remoteproc platform driver can make the proxy
> vote for bus bandwidth.
>
> Signed-off-by: Rishabh Bhatnagar <[email protected]>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 9938918..529b0a0 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -111,6 +111,17 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sm8150-slpi-pas:
> must be "lcx", "lmx", "load_state"
>
> +- interconnect:

This should be plural; "interconnects".

> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: Specifies the interconnect bus-master and bus-slave for
> + bandwidth voting during proxy vote/unvote.
> +
> +- interconnect-names:
> + Usage: optional
> + Value type: <stringlist>
> + Definition: The interconnect name depends on the compatible string

This should be elaborated upon, similar to e.g. power-domain-names.

Regards,
Bjorn

> +
> - memory-region:
> Usage: required
> Value type: <phandle>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project