2020-03-30 10:07:04

by Ding Xiang

Subject: [PATCH] of: remove unneeded variable

rc is unneeded, just return 0.

Signed-off-by: Ding Xiang <[email protected]>
---
drivers/of/dynamic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 08fd823..fe64430 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
{
struct of_reconfig_data rd;
unsigned long flags;
- int rc = 0;

memset(&rd, 0, sizeof(rd));
rd.dn = np;
@@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)

of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);

- return rc;
+ return 0;
}
EXPORT_SYMBOL_GPL(of_detach_node);

--
1.9.1

2020-04-08 18:56:52

by Frank Rowand

Subject: Re: [PATCH] of: remove unneeded variable

On 3/30/20 5:05 AM, Ding Xiang wrote:
> rc is unneeded, just return 0.

of: of_detach_node() remove unneeded local return variable

>
> Signed-off-by: Ding Xiang <[email protected]>
> ---
> drivers/of/dynamic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
> index 08fd823..fe64430 100644
> --- a/drivers/of/dynamic.c
> +++ b/drivers/of/dynamic.c
> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
> {
> struct of_reconfig_data rd;
> unsigned long flags;
> - int rc = 0;
>
> memset(&rd, 0, sizeof(rd));
> rd.dn = np;
> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>
> of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>
> - return rc;
> + return 0;
> }
> EXPORT_SYMBOL_GPL(of_detach_node);
>
>


Reviewed-by: Frank Rowand <[email protected]>

2020-04-08 20:32:15

by Frank Rowand

Subject: Re: [PATCH] of: remove unneeded variable

On 4/8/20 11:00 AM, Frank Rowand wrote:
> On 3/30/20 5:05 AM, Ding Xiang wrote:
>> rc is unneeded, just return 0.
>
> of: of_detach_node() remove unneeded local return variable

never mind, this is not the subject line... My mistake.

-Frank

>
>>
>> Signed-off-by: Ding Xiang <[email protected]>
>> ---
>> drivers/of/dynamic.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
>> index 08fd823..fe64430 100644
>> --- a/drivers/of/dynamic.c
>> +++ b/drivers/of/dynamic.c
>> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
>> {
>> struct of_reconfig_data rd;
>> unsigned long flags;
>> - int rc = 0;
>>
>> memset(&rd, 0, sizeof(rd));
>> rd.dn = np;
>> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>>
>> of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>>
>> - return rc;
>> + return 0;
>> }
>> EXPORT_SYMBOL_GPL(of_detach_node);
>>
>>
>
>
> Reviewed-by: Frank Rowand <[email protected]>
>

2020-04-10 17:39:06

by Rob Herring

Subject: Re: [PATCH] of: remove unneeded variable

On Mon, 30 Mar 2020 18:05:02 +0800, Ding Xiang wrote:
> rc is unneeded, just return 0.
>
> Signed-off-by: Ding Xiang <[email protected]>
> ---
> drivers/of/dynamic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Applied, thanks.

Rob