2020-04-30 12:19:46

by Jason Yan

Subject: [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable

Fix the following coccicheck warning:

drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
bool variable
drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/qedi/qedi_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 4dd965860c98..46584e16d635 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1306,13 +1306,13 @@ static irqreturn_t qedi_msix_handler(int irq, void *dev_id)
"process already running\n");
}

- if (qedi_fp_has_work(fp) == 0)
+ if (!qedi_fp_has_work(fp))
qed_sb_update_sb_idx(fp->sb_info);

/* Check for more work */
rmb();

- if (qedi_fp_has_work(fp) == 0)
+ if (!qedi_fp_has_work(fp))
qed_sb_ack(fp->sb_info, IGU_INT_ENABLE, 1);
else
goto process_again;
--
2.21.1

2020-05-06 04:49:43

by Manish Rangankar

Subject: RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable

> -----Original Message-----
> From: Jason Yan <[email protected]>
> Sent: Thursday, April 30, 2020 5:47 PM
> To: [email protected]; [email protected];
> [email protected]; Manish Rangankar
> <[email protected]>; [email protected]; linux-
> [email protected]
> Cc: Jason Yan <[email protected]>
> Subject: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
> variable
>
> External Email
>
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
>
> drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
> bool variable
> drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/scsi/qedi/qedi_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 4dd965860c98..46584e16d635 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1306,13 +1306,13 @@ static irqreturn_t qedi_msix_handler(int irq,
> void *dev_id)
> "process already running\n");
> }
>
> - if (qedi_fp_has_work(fp) == 0)
> + if (!qedi_fp_has_work(fp))
> qed_sb_update_sb_idx(fp->sb_info);
>
> /* Check for more work */
> rmb();
>
> - if (qedi_fp_has_work(fp) == 0)
> + if (!qedi_fp_has_work(fp))
> qed_sb_ack(fp->sb_info, IGU_INT_ENABLE, 1);
> else
> goto process_again;
> --

Thanks,
Acked-by: Manish Rangankar <[email protected]>

2020-05-08 02:57:53

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable

On Thu, 30 Apr 2020 20:17:06 +0800, Jason Yan wrote:

> Fix the following coccicheck warning:
>
> drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
> bool variable
> drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
> bool variable

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: qedi: Remove comparison of 0/1 to bool variable
https://git.kernel.org/mkp/scsi/c/9187745ceec6

--
Martin K. Petersen Oracle Linux Engineering