2020-05-18 12:24:45

by Wu Bo

Subject: [PATCH] blkcg:Fix memory leaks in blkg_conf_prep()

From: Wu Bo <[email protected]>

If a call of the function blkg_lookup_check() failed,
we should be release the previously allocated block group
before jumping to the lable 'fail_unlock' in the implementation of
the function blkg_conf_prep().

Suggested-by: Markus Elfring <[email protected]>
Signed-off-by: Wu Bo <[email protected]>

---
V2: omit the source code quotation from
the change description

---
block/blk-cgroup.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 930212c..afeb769 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -682,6 +682,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
blkg = blkg_lookup_check(pos, pol, q);
if (IS_ERR(blkg)) {
ret = PTR_ERR(blkg);
+ blkg_free(new_blkg);
goto fail_unlock;
}

--
1.8.3.1

2020-05-18 14:09:30

by Markus Elfring

Subject: Re: [PATCH v2] blkcg: Fix memory leak in blkg_conf_prep()

> If a call of the function blkg_lookup_check() failed,

Thanks that you would like to integrate something from my suggestion.


> we should be release the previously allocated block group

I find that an other wording would be preferred over “we should”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b9bbe6ed63b2b9f2c9ee5cbd0f2c946a2723f4ce#n151


> before jumping to the lable 'fail_unlock' in the implementation of

Please avoid another typo here.


> the function blkg_conf_prep().
>
> Suggested-by: Markus Elfring <[email protected]>

I find this tag questionable because the bug fix was presented before.
https://lore.kernel.org/linux-block/[email protected]/
https://lkml.org/lkml/2020/5/15/779


> ---
> V2: omit the source code quotation from
> the change description

* I recommend to improve also the patch subject accordingly.

* Would you like to move the name from the previous tag into
this information?


> ---
> block/blk-cgroup.c | 1 +

I suggest to omit the triple dashes before this diffstat.

Regards,
Markus

2020-05-26 17:27:49

by Tejun Heo

Subject: Re: [PATCH] blkcg:Fix memory leaks in blkg_conf_prep()

On Mon, May 18, 2020 at 08:36:06PM +0800, Wu Bo wrote:
> From: Wu Bo <[email protected]>
>
> If a call of the function blkg_lookup_check() failed,
> we should be release the previously allocated block group
> before jumping to the lable 'fail_unlock' in the implementation of
> the function blkg_conf_prep().
>
> Suggested-by: Markus Elfring <[email protected]>
> Signed-off-by: Wu Bo <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Thanks.

--
tejun