2020-05-18 14:59:16

by Anson Huang

[permalink] [raw]
Subject: [PATCH 0/3] Covert i.MX GPT/TPM/SYSCTR timer binding to json-schema

This patch series converts i.MX GPT, TPM and system counter timer binding
to json-schema, test build passed.

Anson Huang (3):
dt-bindings: timer: Convert i.MX GPT to json-schema
dt-bindings: timer: Convert i.MX TPM to json-schema
dt-bindings: timer: Convert i.MX SYSCTR to json-schema

.../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ---------
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 109 +++++++++++++++++++++
.../devicetree/bindings/timer/nxp,sysctr-timer.txt | 25 -----
.../bindings/timer/nxp,sysctr-timer.yaml | 54 ++++++++++
.../devicetree/bindings/timer/nxp,tpm-timer.txt | 28 ------
.../devicetree/bindings/timer/nxp,tpm-timer.yaml | 63 ++++++++++++
6 files changed, 226 insertions(+), 98 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
create mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
delete mode 100644 Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml
delete mode 100644 Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml

--
2.7.4


2020-05-18 14:59:26

by Anson Huang

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: timer: Convert i.MX GPT to json-schema

Convert the i.MX GPT binding to DT schema format using json-schema.

Signed-off-by: Anson Huang <[email protected]>
---
.../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ---------
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 109 +++++++++++++++++++++
2 files changed, 109 insertions(+), 45 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
create mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml

diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
deleted file mode 100644
index 5d8fd5b..0000000
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
+++ /dev/null
@@ -1,45 +0,0 @@
-Freescale i.MX General Purpose Timer (GPT)
-
-Required properties:
-
-- compatible : should be one of following:
- for i.MX1:
- - "fsl,imx1-gpt";
- for i.MX21:
- - "fsl,imx21-gpt";
- for i.MX27:
- - "fsl,imx27-gpt", "fsl,imx21-gpt";
- for i.MX31:
- - "fsl,imx31-gpt";
- for i.MX25:
- - "fsl,imx25-gpt", "fsl,imx31-gpt";
- for i.MX50:
- - "fsl,imx50-gpt", "fsl,imx31-gpt";
- for i.MX51:
- - "fsl,imx51-gpt", "fsl,imx31-gpt";
- for i.MX53:
- - "fsl,imx53-gpt", "fsl,imx31-gpt";
- for i.MX6Q:
- - "fsl,imx6q-gpt", "fsl,imx31-gpt";
- for i.MX6DL:
- - "fsl,imx6dl-gpt";
- for i.MX6SL:
- - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt";
- for i.MX6SX:
- - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt";
-- reg : specifies base physical address and size of the registers.
-- interrupts : should be the gpt interrupt.
-- clocks : the clocks provided by the SoC to drive the timer, must contain
- an entry for each entry in clock-names.
-- clock-names : must include "ipg" entry first, then "per" entry.
-
-Example:
-
-gpt1: timer@10003000 {
- compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
- reg = <0x10003000 0x1000>;
- interrupts = <26>;
- clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
- <&clks IMX27_CLK_PER1_GATE>;
- clock-names = "ipg", "per";
-};
diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
new file mode 100644
index 0000000..5c7186b
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -0,0 +1,109 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX General Purpose Timer (GPT)
+
+maintainers:
+ - Sascha Hauer <[email protected]>
+
+properties:
+ compatible:
+ oneOf:
+ - description: on i.MX1 the following compatible must be specified
+ items:
+ - const: "fsl,imx1-gpt"
+
+ - description: on i.MX21 the following compatible must be specified
+ items:
+ - const: "fsl,imx21-gpt"
+
+ - description: on i.MX27 the following compatibles must be specified
+ items:
+ - const: "fsl,imx27-gpt"
+ - const: "fsl,imx21-gpt"
+
+ - description: on i.MX31 the following compatible must be specified
+ items:
+ - const: "fsl,imx31-gpt"
+
+ - description: on i.MX25 the following compatibles must be specified
+ items:
+ - const: "fsl,imx25-gpt"
+ - const: "fsl,imx31-gpt"
+
+ - description: on i.MX50 the following compatibles must be specified
+ items:
+ - const: "fsl,imx50-gpt"
+ - const: "fsl,imx31-gpt"
+
+ - description: on i.MX51 the following compatibles must be specified
+ items:
+ - const: "fsl,imx51-gpt"
+ - const: "fsl,imx31-gpt"
+
+ - description: on i.MX53 the following compatibles must be specified
+ items:
+ - const: "fsl,imx53-gpt"
+ - const: "fsl,imx31-gpt"
+
+ - description: on i.MX6Q the following compatibles must be specified
+ items:
+ - const: "fsl,imx6q-gpt"
+ - const: "fsl,imx31-gpt"
+
+ - description: on i.MX6DL the following compatible must be specified
+ items:
+ - const: "fsl,imx6dl-gpt"
+
+ - description: on i.MX6SL the following compatibles must be specified
+ items:
+ - const: "fsl,imx6sl-gpt"
+ - const: "fsl,imx6dl-gpt"
+
+ - description: on i.MX6SX the following compatibles must be specified
+ items:
+ - const: "fsl,imx6sx-gpt"
+ - const: "fsl,imx6dl-gpt"
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: SoC GPT ipg clock
+ - description: SoC GPT per clock
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: ipg
+ - const: per
+ maxItems: 2
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx27-clock.h>
+
+ timer@10003000 {
+ compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
+ reg = <0x10003000 0x1000>;
+ interrupts = <26>;
+ clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
+ <&clks IMX27_CLK_PER1_GATE>;
+ clock-names = "ipg", "per";
+ };
--
2.7.4

2020-05-18 15:02:04

by Anson Huang

[permalink] [raw]
Subject: [PATCH 2/3] dt-bindings: timer: Convert i.MX TPM to json-schema

Convert the i.MX TPM binding to DT schema format using json-schema.

Signed-off-by: Anson Huang <[email protected]>
---
.../devicetree/bindings/timer/nxp,tpm-timer.txt | 28 ----------
.../devicetree/bindings/timer/nxp,tpm-timer.yaml | 63 ++++++++++++++++++++++
2 files changed, 63 insertions(+), 28 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml

diff --git a/Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt b/Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
deleted file mode 100644
index f82087b..0000000
--- a/Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-NXP Low Power Timer/Pulse Width Modulation Module (TPM)
-
-The Timer/PWM Module (TPM) supports input capture, output compare,
-and the generation of PWM signals to control electric motor and power
-management applications. The counter, compare and capture registers
-are clocked by an asynchronous clock that can remain enabled in low
-power modes. TPM can support global counter bus where one TPM drives
-the counter bus for the others, provided bit width is the same.
-
-Required properties:
-
-- compatible : should be "fsl,imx7ulp-tpm"
-- reg : Specifies base physical address and size of the register sets
- for the clock event device and clock source device.
-- interrupts : Should be the clock event device interrupt.
-- clocks : The clocks provided by the SoC to drive the timer, must contain
- an entry for each entry in clock-names.
-- clock-names : Must include the following entries: "ipg" and "per".
-
-Example:
-tpm5: tpm@40260000 {
- compatible = "fsl,imx7ulp-tpm";
- reg = <0x40260000 0x1000>;
- interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7ULP_CLK_NIC1_BUS_DIV>,
- <&clks IMX7ULP_CLK_LPTPM5>;
- clock-names = "ipg", "per";
-};
diff --git a/Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml b/Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml
new file mode 100644
index 0000000..0d34610
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/nxp,tpm-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP Low Power Timer/Pulse Width Modulation Module (TPM)
+
+maintainers:
+ - Dong Aisheng <[email protected]>
+
+description: |
+ The Timer/PWM Module (TPM) supports input capture, output compare,
+ and the generation of PWM signals to control electric motor and power
+ management applications. The counter, compare and capture registers
+ are clocked by an asynchronous clock that can remain enabled in low
+ power modes. TPM can support global counter bus where one TPM drives
+ the counter bus for the others, provided bit width is the same.
+
+properties:
+ compatible:
+ const: fsl,imx7ulp-tpm
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: SoC TPM ipg clock
+ - description: SoC TPM per clock
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: ipg
+ - const: per
+ maxItems: 2
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx7ulp-clock.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ timer@40260000 {
+ compatible = "fsl,imx7ulp-tpm";
+ reg = <0x40260000 0x1000>;
+ interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>,
+ <&pcc2 IMX7ULP_CLK_LPTPM5>;
+ clock-names = "ipg", "per";
+ };
--
2.7.4

2020-05-18 15:02:10

by Anson Huang

[permalink] [raw]
Subject: [PATCH 3/3] dt-bindings: timer: Convert i.MX SYSCTR to json-schema

Convert the i.MX SYSCTR binding to DT schema format using json-schema.

Signed-off-by: Anson Huang <[email protected]>
---
.../devicetree/bindings/timer/nxp,sysctr-timer.txt | 25 ----------
.../bindings/timer/nxp,sysctr-timer.yaml | 54 ++++++++++++++++++++++
2 files changed, 54 insertions(+), 25 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml

diff --git a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
deleted file mode 100644
index d576599..0000000
--- a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-NXP System Counter Module(sys_ctr)
-
-The system counter(sys_ctr) is a programmable system counter which provides
-a shared time base to Cortex A15, A7, A53, A73, etc. it is intended for use in
-applications where the counter is always powered and support multiple,
-unrelated clocks. The compare frame inside can be used for timer purpose.
-
-Required properties:
-
-- compatible : should be "nxp,sysctr-timer"
-- reg : Specifies the base physical address and size of the comapre
- frame and the counter control, read & compare.
-- interrupts : should be the first compare frames' interrupt
-- clocks : Specifies the counter clock.
-- clock-names: Specifies the clock's name of this module
-
-Example:
-
- system_counter: timer@306a0000 {
- compatible = "nxp,sysctr-timer";
- reg = <0x306a0000 0x20000>;/* system-counter-rd & compare */
- clocks = <&clk_8m>;
- clock-names = "per";
- interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
- };
diff --git a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml
new file mode 100644
index 0000000..830211c
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/nxp,sysctr-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP System Counter Module(sys_ctr)
+
+maintainers:
+ - Bai Ping <[email protected]>
+
+description: |
+ The system counter(sys_ctr) is a programmable system counter
+ which provides a shared time base to Cortex A15, A7, A53, A73,
+ etc. it is intended for use in applications where the counter
+ is always powered and support multiple, unrelated clocks. The
+ compare frame inside can be used for timer purpose.
+
+properties:
+ compatible:
+ const: nxp,sysctr-timer
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: per
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ timer@306a0000 {
+ compatible = "nxp,sysctr-timer";
+ reg = <0x306a0000 0x20000>;
+ clocks = <&clk_8m>;
+ clock-names = "per";
+ interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
+ };
--
2.7.4

2020-05-19 02:50:32

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH 1/3] dt-bindings: timer: Convert i.MX GPT to json-schema

> From: Anson Huang <[email protected]>
> Sent: Monday, May 18, 2020 10:48 PM
>
> Convert the i.MX GPT binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> .../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ---------
> .../devicetree/bindings/timer/fsl,imxgpt.yaml | 109
> +++++++++++++++++++++
> 2 files changed, 109 insertions(+), 45 deletions(-) delete mode 100644
> Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> create mode 100644
> Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> deleted file mode 100644
> index 5d8fd5b..0000000
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -Freescale i.MX General Purpose Timer (GPT)
> -
> -Required properties:
> -
> -- compatible : should be one of following:
> - for i.MX1:
> - - "fsl,imx1-gpt";
> - for i.MX21:
> - - "fsl,imx21-gpt";
> - for i.MX27:
> - - "fsl,imx27-gpt", "fsl,imx21-gpt";
> - for i.MX31:
> - - "fsl,imx31-gpt";
> - for i.MX25:
> - - "fsl,imx25-gpt", "fsl,imx31-gpt";
> - for i.MX50:
> - - "fsl,imx50-gpt", "fsl,imx31-gpt";
> - for i.MX51:
> - - "fsl,imx51-gpt", "fsl,imx31-gpt";
> - for i.MX53:
> - - "fsl,imx53-gpt", "fsl,imx31-gpt";
> - for i.MX6Q:
> - - "fsl,imx6q-gpt", "fsl,imx31-gpt";
> - for i.MX6DL:
> - - "fsl,imx6dl-gpt";
> - for i.MX6SL:
> - - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt";
> - for i.MX6SX:
> - - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt";
> -- reg : specifies base physical address and size of the registers.
> -- interrupts : should be the gpt interrupt.
> -- clocks : the clocks provided by the SoC to drive the timer, must contain
> - an entry for each entry in clock-names.
> -- clock-names : must include "ipg" entry first, then "per" entry.
> -
> -Example:
> -
> -gpt1: timer@10003000 {
> - compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
> - reg = <0x10003000 0x1000>;
> - interrupts = <26>;
> - clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
> - <&clks IMX27_CLK_PER1_GATE>;
> - clock-names = "ipg", "per";
> -};
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> new file mode 100644
> index 0000000..5c7186b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -0,0 +1,109 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> +---
> +
> +title: Freescale i.MX General Purpose Timer (GPT)
> +
> +maintainers:
> + - Sascha Hauer <[email protected]>
> +
> +properties:
> + compatible:
> + oneOf:
> + - description: on i.MX1 the following compatible must be specified

Such a description seems not necessary in order to make the doc more clean

> + items:
> + - const: "fsl,imx1-gpt"
> +
> + - description: on i.MX21 the following compatible must be specified
> + items:
> + - const: "fsl,imx21-gpt"
> +
> + - description: on i.MX27 the following compatibles must be specified
> + items:
> + - const: "fsl,imx27-gpt"
> + - const: "fsl,imx21-gpt"
> +
> + - description: on i.MX31 the following compatible must be specified
> + items:
> + - const: "fsl,imx31-gpt"
> +
> + - description: on i.MX25 the following compatibles must be specified
> + items:
> + - const: "fsl,imx25-gpt"
> + - const: "fsl,imx31-gpt"
> +
> + - description: on i.MX50 the following compatibles must be specified
> + items:
> + - const: "fsl,imx50-gpt"
> + - const: "fsl,imx31-gpt"
> +
> + - description: on i.MX51 the following compatibles must be specified
> + items:
> + - const: "fsl,imx51-gpt"
> + - const: "fsl,imx31-gpt"
> +
> + - description: on i.MX53 the following compatibles must be specified
> + items:
> + - const: "fsl,imx53-gpt"
> + - const: "fsl,imx31-gpt"
> +
> + - description: on i.MX6Q the following compatibles must be specified
> + items:
> + - const: "fsl,imx6q-gpt"
> + - const: "fsl,imx31-gpt"
> +
> + - description: on i.MX6DL the following compatible must be specified
> + items:
> + - const: "fsl,imx6dl-gpt"
> +
> + - description: on i.MX6SL the following compatibles must be specified
> + items:
> + - const: "fsl,imx6sl-gpt"
> + - const: "fsl,imx6dl-gpt"
> +
> + - description: on i.MX6SX the following compatibles must be specified
> + items:
> + - const: "fsl,imx6sx-gpt"
> + - const: "fsl,imx6dl-gpt"
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + maxItems: 2

maxItems is not needed

> +
> + clock-names:
> + items:
> + - const: ipg
> + - const: per
> + maxItems: 2

Ditto

> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx27-clock.h>
> +
> + timer@10003000 {
> + compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
> + reg = <0x10003000 0x1000>;
> + interrupts = <26>;
> + clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
> + <&clks IMX27_CLK_PER1_GATE>;
> + clock-names = "ipg", "per";
> + };
> --
> 2.7.4

2020-05-19 02:51:49

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH 2/3] dt-bindings: timer: Convert i.MX TPM to json-schema

> From: Anson Huang <[email protected]>
> Sent: Monday, May 18, 2020 10:48 PM
>
> Convert the i.MX TPM binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> .../devicetree/bindings/timer/nxp,tpm-timer.txt | 28 ----------
> .../devicetree/bindings/timer/nxp,tpm-timer.yaml | 63
> ++++++++++++++++++++++
> 2 files changed, 63 insertions(+), 28 deletions(-) delete mode 100644
> Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
> create mode 100644
> Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
> b/Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
> deleted file mode 100644
> index f82087b..0000000
> --- a/Documentation/devicetree/bindings/timer/nxp,tpm-timer.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -NXP Low Power Timer/Pulse Width Modulation Module (TPM)
> -
> -The Timer/PWM Module (TPM) supports input capture, output compare, -and
> the generation of PWM signals to control electric motor and power
> -management applications. The counter, compare and capture registers -are
> clocked by an asynchronous clock that can remain enabled in low -power modes.
> TPM can support global counter bus where one TPM drives -the counter bus for
> the others, provided bit width is the same.
> -
> -Required properties:
> -
> -- compatible : should be "fsl,imx7ulp-tpm"
> -- reg : Specifies base physical address and size of the register sets
> - for the clock event device and clock source device.
> -- interrupts : Should be the clock event device interrupt.
> -- clocks : The clocks provided by the SoC to drive the timer, must contain
> - an entry for each entry in clock-names.
> -- clock-names : Must include the following entries: "ipg" and "per".
> -
> -Example:
> -tpm5: tpm@40260000 {
> - compatible = "fsl,imx7ulp-tpm";
> - reg = <0x40260000 0x1000>;
> - interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7ULP_CLK_NIC1_BUS_DIV>,
> - <&clks IMX7ULP_CLK_LPTPM5>;
> - clock-names = "ipg", "per";
> -};
> diff --git a/Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml
> b/Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml
> new file mode 100644
> index 0000000..0d34610
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/nxp,tpm-timer.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2

[...]

> +
> +title: NXP Low Power Timer/Pulse Width Modulation Module (TPM)
> +
> +maintainers:
> + - Dong Aisheng <[email protected]>
> +
> +description: |
> + The Timer/PWM Module (TPM) supports input capture, output compare,
> + and the generation of PWM signals to control electric motor and power
> + management applications. The counter, compare and capture registers
> + are clocked by an asynchronous clock that can remain enabled in low
> + power modes. TPM can support global counter bus where one TPM drives
> + the counter bus for the others, provided bit width is the same.
> +
> +properties:
> + compatible:
> + const: fsl,imx7ulp-tpm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: SoC TPM ipg clock
> + - description: SoC TPM per clock

> + maxItems: 2

Unneeded line

> +
> + clock-names:
> + items:
> + - const: ipg
> + - const: per

> + maxItems: 2

Ditto

Otherwise:

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx7ulp-clock.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + timer@40260000 {
> + compatible = "fsl,imx7ulp-tpm";
> + reg = <0x40260000 0x1000>;
> + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>,
> + <&pcc2 IMX7ULP_CLK_LPTPM5>;
> + clock-names = "ipg", "per";
> + };
> --
> 2.7.4

2020-05-19 02:53:48

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH 3/3] dt-bindings: timer: Convert i.MX SYSCTR to json-schema

> From: Anson Huang <[email protected]>
> Sent: Monday, May 18, 2020 10:48 PM
>
> Convert the i.MX SYSCTR binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

2020-05-19 03:07:38

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH 1/3] dt-bindings: timer: Convert i.MX GPT to json-schema



> Subject: RE: [PATCH 1/3] dt-bindings: timer: Convert i.MX GPT to json-schema
>
> > From: Anson Huang <[email protected]>
> > Sent: Monday, May 18, 2020 10:48 PM
> >
> > Convert the i.MX GPT binding to DT schema format using json-schema.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > .../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ---------
> > .../devicetree/bindings/timer/fsl,imxgpt.yaml | 109
> > +++++++++++++++++++++
> > 2 files changed, 109 insertions(+), 45 deletions(-) delete mode
> > 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> > create mode 100644
> > Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> > b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> > deleted file mode 100644
> > index 5d8fd5b..0000000
> > --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
> > +++ /dev/null
> > @@ -1,45 +0,0 @@
> > -Freescale i.MX General Purpose Timer (GPT)
> > -
> > -Required properties:
> > -
> > -- compatible : should be one of following:
> > - for i.MX1:
> > - - "fsl,imx1-gpt";
> > - for i.MX21:
> > - - "fsl,imx21-gpt";
> > - for i.MX27:
> > - - "fsl,imx27-gpt", "fsl,imx21-gpt";
> > - for i.MX31:
> > - - "fsl,imx31-gpt";
> > - for i.MX25:
> > - - "fsl,imx25-gpt", "fsl,imx31-gpt";
> > - for i.MX50:
> > - - "fsl,imx50-gpt", "fsl,imx31-gpt";
> > - for i.MX51:
> > - - "fsl,imx51-gpt", "fsl,imx31-gpt";
> > - for i.MX53:
> > - - "fsl,imx53-gpt", "fsl,imx31-gpt";
> > - for i.MX6Q:
> > - - "fsl,imx6q-gpt", "fsl,imx31-gpt";
> > - for i.MX6DL:
> > - - "fsl,imx6dl-gpt";
> > - for i.MX6SL:
> > - - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt";
> > - for i.MX6SX:
> > - - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt";
> > -- reg : specifies base physical address and size of the registers.
> > -- interrupts : should be the gpt interrupt.
> > -- clocks : the clocks provided by the SoC to drive the timer, must contain
> > - an entry for each entry in clock-names.
> > -- clock-names : must include "ipg" entry first, then "per" entry.
> > -
> > -Example:
> > -
> > -gpt1: timer@10003000 {
> > - compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
> > - reg = <0x10003000 0x1000>;
> > - interrupts = <26>;
> > - clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
> > - <&clks IMX27_CLK_PER1_GATE>;
> > - clock-names = "ipg", "per";
> > -};
> > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> > b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> > new file mode 100644
> > index 0000000..5c7186b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> > @@ -0,0 +1,109 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +
> > +title: Freescale i.MX General Purpose Timer (GPT)
> > +
> > +maintainers:
> > + - Sascha Hauer <[email protected]>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - description: on i.MX1 the following compatible must be
> > +specified
>
> Such a description seems not necessary in order to make the doc more clean

You meant the description is NOT necessary for those simple compatible string platforms or for
all platforms, I feel like having the description is more clear for users.

Anson