Add missing include to fix build error:
hibmc_drm_drv.c:385:1: warning: data definition has no type or storage
class [enabled by default]
hibmc_drm_drv.c:385:1: error: type defaults to ‘int’ in declaration
of ‘module_init’ [-Werror=implicit-int]
hibmc_drm_drv.c:385:1: warning: parameter names (without types) in function
of ‘module_exit’ [-Werror=implicit-int]
hibmc_drm_drv.c:385:292:1: warning: parameter names (without types) in
function declaration [enabled by default]
Signed-off-by: Tian Tao <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 1ae360d..2b4f821 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -11,6 +11,7 @@
* Jianhua Li <[email protected]>
*/
+#include <linux/module.h>
#include <linux/pci.h>
#include <drm/drm_atomic_helper.h>
--
2.7.4
Hi
Am 13.08.20 um 05:39 schrieb Tian Tao:
> Add missing include to fix build error:
> hibmc_drm_drv.c:385:1: warning: data definition has no type or storage
> class [enabled by default]
> hibmc_drm_drv.c:385:1: error: type defaults to ‘int’ in declaration
> of ‘module_init’ [-Werror=implicit-int]
> hibmc_drm_drv.c:385:1: warning: parameter names (without types) in function
> of ‘module_exit’ [-Werror=implicit-int]
> hibmc_drm_drv.c:385:292:1: warning: parameter names (without types) in
> function declaration [enabled by default]
>
> Signed-off-by: Tian Tao <[email protected]>
> Reported-by: kernel test robot <[email protected]>
Reviewed-by: Thomas Zimmermann <[email protected]>
I pushed the patch to drm-misc-next, but forgot to add my R-b tag. If
anyone complains, it's my fault.
Best regards
Thomas
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index 1ae360d..2b4f821 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -11,6 +11,7 @@
> * Jianhua Li <[email protected]>
> */
>
> +#include <linux/module.h>
> #include <linux/pci.h>
>
> #include <drm/drm_atomic_helper.h>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
On Thu, Aug 13, 2020 at 10:03:18AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 13.08.20 um 05:39 schrieb Tian Tao:
> > Add missing include to fix build error:
> > hibmc_drm_drv.c:385:1: warning: data definition has no type or storage
> > class [enabled by default]
> > hibmc_drm_drv.c:385:1: error: type defaults to ‘int’ in declaration
> > of ‘module_init’ [-Werror=implicit-int]
> > hibmc_drm_drv.c:385:1: warning: parameter names (without types) in function
> > of ‘module_exit’ [-Werror=implicit-int]
> > hibmc_drm_drv.c:385:292:1: warning: parameter names (without types) in
> > function declaration [enabled by default]
> >
> > Signed-off-by: Tian Tao <[email protected]>
> > Reported-by: kernel test robot <[email protected]>
>
> Reviewed-by: Thomas Zimmermann <[email protected]>
>
> I pushed the patch to drm-misc-next, but forgot to add my R-b tag. If
> anyone complains, it's my fault.
sob implies r-b generally, most maintainers do it like that and don't add
both their sob and r-b tag. That's also why dim doesn't enforce an r-b tag
in this case.
-Daniel
>
> Best regards
> Thomas
>
> > ---
> > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> > index 1ae360d..2b4f821 100644
> > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> > @@ -11,6 +11,7 @@
> > * Jianhua Li <[email protected]>
> > */
> >
> > +#include <linux/module.h>
> > #include <linux/pci.h>
> >
> > #include <drm/drm_atomic_helper.h>
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch