Remove output-high from CTS and TX as this is not really required. During
bringup to fix transfer failures this was added to match with console uart
settings. Probably some boot loader config was missing then. As it is
working fine now, remove it.
Signed-off-by: satya priya <[email protected]>
Reviewed-by: Akash Asthana <[email protected]>
Reviewed-by: Matthias Kaehlcke <[email protected]>
---
Changes in V4:
- This is newly added in V4 to separate the improvements in pin settings
and wakeup related changes.
Changes in V5:
- As per Doug's comment configured pull-down for CTS pin as earlier.
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index d8b5507..04888df 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -474,32 +474,30 @@
&qup_uart3_default {
pinconf-cts {
/*
- * Configure a pull-down on 38 (CTS) to match the pull of
+ * Configure a pull-down on CTS to match the pull of
* the Bluetooth module.
*/
pins = "gpio38";
bias-pull-down;
- output-high;
};
pinconf-rts {
- /* We'll drive 39 (RTS), so no pull */
+ /* We'll drive RTS, so no pull */
pins = "gpio39";
drive-strength = <2>;
bias-disable;
};
pinconf-tx {
- /* We'll drive 40 (TX), so no pull */
+ /* We'll drive TX, so no pull */
pins = "gpio40";
drive-strength = <2>;
bias-disable;
- output-high;
};
pinconf-rx {
/*
- * Configure a pull-up on 41 (RX). This is needed to avoid
+ * Configure a pull-up on RX. This is needed to avoid
* garbage data when the TX pin of the Bluetooth module is
* in tri-state (module powered off or not driving the
* signal yet).
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Hi,
On Thu, Sep 10, 2020 at 5:55 AM satya priya <[email protected]> wrote:
>
> Remove output-high from CTS and TX as this is not really required. During
> bringup to fix transfer failures this was added to match with console uart
> settings. Probably some boot loader config was missing then. As it is
> working fine now, remove it.
>
> Signed-off-by: satya priya <[email protected]>
> Reviewed-by: Akash Asthana <[email protected]>
> Reviewed-by: Matthias Kaehlcke <[email protected]>
> ---
> Changes in V4:
> - This is newly added in V4 to separate the improvements in pin settings
> and wakeup related changes.
>
> Changes in V5:
> - As per Doug's comment configured pull-down for CTS pin as earlier.
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Looks fine to me. Slight nit that this only applies to the IDP board
but ${SUBJECT} makes it sound as if this applies to all sc7180. I
wouldn't spin just for that, though. If Bjorn agrees, he can always
adjust the subject when applying.
Reviewed-by: Douglas Anderson <[email protected]>
Hi Doug,
On 2020-09-10 20:10, Doug Anderson wrote:
> Hi,
>
> On Thu, Sep 10, 2020 at 5:55 AM satya priya <[email protected]>
> wrote:
>>
>> Remove output-high from CTS and TX as this is not really required.
>> During
>> bringup to fix transfer failures this was added to match with console
>> uart
>> settings. Probably some boot loader config was missing then. As it is
>> working fine now, remove it.
>>
>> Signed-off-by: satya priya <[email protected]>
>> Reviewed-by: Akash Asthana <[email protected]>
>> Reviewed-by: Matthias Kaehlcke <[email protected]>
>> ---
>> Changes in V4:
>> - This is newly added in V4 to separate the improvements in pin
>> settings
>> and wakeup related changes.
>>
>> Changes in V5:
>> - As per Doug's comment configured pull-down for CTS pin as earlier.
>>
>> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 10 ++++------
>> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> Looks fine to me. Slight nit that this only applies to the IDP board
> but ${SUBJECT} makes it sound as if this applies to all sc7180. I
> wouldn't spin just for that, though. If Bjorn agrees, he can always
> adjust the subject when applying.
>
> Reviewed-by: Douglas Anderson <[email protected]>
Thanks for reviewing the patches, i will correct this nit in my next
version.
Thanks,
Satya Priya