2020-11-27 08:49:11

by Xingxing Su

Subject: [PATCH v2] selftests/clone3: Fix build error

When compiling the selftests with the -std=gnu99 option the build can
fail with.

Following build error:

test_core.c: In function ‘test_cgcore_destroy’:
test_core.c:87:2: error: ‘for’ loop initial declarations are only
allowed in C99 mode
for (int i = 0; i < 10; i++) {
^
test_core.c:87:2: note: use option -std=c99 or -std=gnu99 to compile

Add -std=gnu99 to the clone3 selftest Makefile to fix this.

Signed-off-by: Xingxing Su <[email protected]>
Acked-by: Christian Brauner <[email protected]>
---
tools/testing/selftests/clone3/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile
index ef7564c..88354a8 100644
--- a/tools/testing/selftests/clone3/Makefile
+++ b/tools/testing/selftests/clone3/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-CFLAGS += -g -I../../../../usr/include/
+CFLAGS += -g -std=gnu99 -I../../../../usr/include/
LDLIBS += -lcap

TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \
--
1.8.3.1

2020-12-07 22:06:35

by Shuah Khan

Subject: Re: [PATCH v2] selftests/clone3: Fix build error

On 11/26/20 8:16 PM, Xingxing Su wrote:
> When compiling the selftests with the -std=gnu99 option the build can
> fail with.
>
> Following build error:
>
> test_core.c: In function ‘test_cgcore_destroy’:
> test_core.c:87:2: error: ‘for’ loop initial declarations are only
> allowed in C99 mode
> for (int i = 0; i < 10; i++) {
> ^
> test_core.c:87:2: note: use option -std=c99 or -std=gnu99 to compile
>
> Add -std=gnu99 to the clone3 selftest Makefile to fix this.
>
> Signed-off-by: Xingxing Su <[email protected]>
> Acked-by: Christian Brauner <[email protected]>
> ---
> tools/testing/selftests/clone3/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile
> index ef7564c..88354a8 100644
> --- a/tools/testing/selftests/clone3/Makefile
> +++ b/tools/testing/selftests/clone3/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -g -I../../../../usr/include/
> +CFLAGS += -g -std=gnu99 -I../../../../usr/include/
> LDLIBS += -lcap
>
> TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \
>

Applied to linux-kselftest fixes for 5.11-rc1

thanks,
-- Shuah