2020-12-11 00:48:44

by Zou Wei

Subject: [PATCH -next] lib/ubsan.c: Mark type_check_kinds with static keyword

Fix the following sparse warning:

lib/ubsan.c:20:12: warning: symbol 'type_check_kinds' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
lib/ubsan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ubsan.c b/lib/ubsan.c
index cb9af3f6..3cfe902 100644
--- a/lib/ubsan.c
+++ b/lib/ubsan.c
@@ -17,7 +17,7 @@

#include "ubsan.h"

-const char *type_check_kinds[] = {
+static const char *type_check_kinds[] = {
"load of",
"store to",
"reference binding to",
--
2.6.2

2020-12-11 19:08:02

by Kees Cook

Subject: Re: [PATCH -next] lib/ubsan.c: Mark type_check_kinds with static keyword

On Thu, Dec 10, 2020 at 08:17:18PM +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> lib/ubsan.c:20:12: warning: symbol 'type_check_kinds' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook