2021-02-02 06:53:59

by Yang Li

Subject: [PATCH] apei: erst: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/acpi/apei/erst.c:691:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/acpi/apei/erst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index 2e0b0fc..b959721 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -688,7 +688,7 @@ static int __erst_read_from_storage(u64 record_id, u64 offset)
break;
if (erst_timedout(&timeout, SPIN_UNIT))
return -EIO;
- };
+ }
rc = apei_exec_run(&ctx, ACPI_ERST_GET_COMMAND_STATUS);
if (rc)
return rc;
--
1.8.3.1

2021-02-06 00:22:57

by Rafael J. Wysocki

Subject: Re: [PATCH] apei: erst: remove unneeded semicolon

On Tue, Feb 2, 2021 at 7:52 AM Yang Li <[email protected]> wrote:
>
> Eliminate the following coccicheck warning:
> ./drivers/acpi/apei/erst.c:691:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/acpi/apei/erst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index 2e0b0fc..b959721 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -688,7 +688,7 @@ static int __erst_read_from_storage(u64 record_id, u64 offset)
> break;
> if (erst_timedout(&timeout, SPIN_UNIT))
> return -EIO;
> - };
> + }
> rc = apei_exec_run(&ctx, ACPI_ERST_GET_COMMAND_STATUS);
> if (rc)
> return rc;
> --

Applied as 5.12 material, thanks!