2021-02-25 09:58:02

by Yang Li

Subject: [PATCH] ARM: OMAP2+: add missing call to of_node_put()

In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().

Fix the following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:2132:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2140.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
arch/arm/mach-omap2/omap_hwmod.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 2310cd5..007e91e 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -2137,6 +2137,7 @@ static int of_dev_hwmod_lookup(struct device_node *np,
if (res == 0) {
*found = fc;
*index = i;
+ of_node_put(np0);
return 0;
}
}
--
1.8.3.1

2021-03-24 12:19:34

by Tony Lindgren

Subject: Re: [PATCH] ARM: OMAP2+: add missing call to of_node_put()

* Yang Li <[email protected]> [210225 10:55]:
> In one of the error paths of the for_each_child_of_node() loop,
> add missing call to of_node_put().

Thanks applying into omap-for-v5.13/soc.

Tony