2021-02-26 01:36:41

by Yang Li

Subject: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()

In one of the error paths of the for_each_child_of_node() loop in
ingenic_gpio_probe, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2489.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---

Changes in v2:
-add braces for if

drivers/pinctrl/pinctrl-ingenic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index f274612..c8ecd01 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -2485,8 +2485,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
for_each_child_of_node(dev->of_node, node) {
if (of_match_node(ingenic_gpio_of_match, node)) {
err = ingenic_gpio_probe(jzpc, node);
- if (err)
+ if (err) {
+ of_node_put(node);
return err;
+ }
}
}

--
1.8.3.1

2021-02-26 14:25:46

by Paul Cercueil

Subject: Re: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()

Hi,

Le ven. 26 f?vr. 2021 ? 9:34, Yang Li <[email protected]> a
?crit :
> In one of the error paths of the for_each_child_of_node() loop in
> ingenic_gpio_probe, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return
> around
> line 2489.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Acked-by: Paul Cercueil <[email protected]>

Cheers,
-Paul

> ---
>
> Changes in v2:
> -add braces for if
>
> drivers/pinctrl/pinctrl-ingenic.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index f274612..c8ecd01 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -2485,8 +2485,10 @@ static int __init ingenic_pinctrl_probe(struct
> platform_device *pdev)
> for_each_child_of_node(dev->of_node, node) {
> if (of_match_node(ingenic_gpio_of_match, node)) {
> err = ingenic_gpio_probe(jzpc, node);
> - if (err)
> + if (err) {
> + of_node_put(node);
> return err;
> + }
> }
> }
>
> --
> 1.8.3.1
>

2021-03-04 21:45:36

by Linus Walleij

Subject: Re: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()

On Fri, Feb 26, 2021 at 2:35 AM Yang Li <[email protected]> wrote:

> In one of the error paths of the for_each_child_of_node() loop in
> ingenic_gpio_probe, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 2489.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Oops applied this rather than v1.

Yours,
Linus Walleij