2021-03-11 07:13:57

by Jiapeng Chong

Subject: [PATCH v2] netdevsim: fib: Remove redundant code

Fix the following coccicheck warnings:

./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return
"0" on line 889.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
- Modify the function type to void.

drivers/net/netdevsim/fib.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..3ca0f54 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -869,10 +869,8 @@ static int nsim_fib6_event(struct nsim_fib_data *data,
return err;
}

-static int nsim_fib_event(struct nsim_fib_event *fib_event)
+static void nsim_fib_event(struct nsim_fib_event *fib_event)
{
- int err = 0;
-
switch (fib_event->family) {
case AF_INET:
nsim_fib4_event(fib_event->data, &fib_event->fen_info,
@@ -885,8 +883,6 @@ static int nsim_fib_event(struct nsim_fib_event *fib_event)
nsim_fib6_event_fini(&fib_event->fib6_event);
break;
}
-
- return err;
}

static int nsim_fib4_prepare_event(struct fib_notifier_info *info,
--
1.8.3.1

2021-03-11 20:43:20

by Jakub Kicinski

Subject: Re: [PATCH v2] netdevsim: fib: Remove redundant code

On Thu, 11 Mar 2021 15:11:01 +0800 Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return
> "0" on line 889.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Jakub Kicinski <[email protected]>

2021-03-12 00:11:44

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] netdevsim: fib: Remove redundant code

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 11 Mar 2021 15:11:01 +0800 you wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return
> "0" on line 889.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- [v2] netdevsim: fib: Remove redundant code
https://git.kernel.org/netdev/net-next/c/c53d21af674a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html