2021-03-27 10:39:27

by Huang Guobin

Subject: [PATCH net-next v2] net: moxa: remove redundant dev_err call in moxart_mac_probe()

From: Guobin Huang <[email protected]>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Guobin Huang <[email protected]>
---
drivers/net/ethernet/moxa/moxart_ether.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 49fd843c4c8a..b85733942053 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -485,7 +485,6 @@ static int moxart_mac_probe(struct platform_device *pdev)
ndev->base_addr = res->start;
priv->base = devm_ioremap_resource(p_dev, res);
if (IS_ERR(priv->base)) {
- dev_err(p_dev, "devm_ioremap_resource failed\n");
ret = PTR_ERR(priv->base);
goto init_fail;
}

2021-03-29 01:14:16

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next v2] net: moxa: remove redundant dev_err call in moxart_mac_probe()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 18:37:54 +0800 you wrote:
> From: Guobin Huang <[email protected]>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Guobin Huang <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next,v2] net: moxa: remove redundant dev_err call in moxart_mac_probe()
https://git.kernel.org/netdev/net-next/c/9d0365448b5b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html