2021-04-01 07:01:44

by Norman Maurer

Subject: [PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

From: Norman Maurer <[email protected]>

Support for UDP_GRO was added in the past but the implementation for
getsockopt was missed which did lead to an error when we tried to
retrieve the setting for UDP_GRO. This patch adds the missing switch
case for UDP_GRO

Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
Signed-off-by: Norman Maurer <[email protected]>
---
net/ipv4/udp.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 4a0478b17243..99d743eb9dc4 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -2754,6 +2754,10 @@ int udp_lib_getsockopt(struct sock *sk, int level, int optname,
val = up->gso_size;
break;

+ case UDP_GRO:
+ val = up->gro_enabled;
+ break;
+
/* The following two cannot be changed on UDP sockets, the return is
* always 0 (which corresponds to the full checksum coverage of UDP). */
case UDPLITE_SEND_CSCOV:
--
2.30.2

2021-04-01 18:23:27

by David Ahern

Subject: Re: [PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

On 4/1/21 12:59 AM, Norman Maurer wrote:
> From: Norman Maurer <[email protected]>
>
> Support for UDP_GRO was added in the past but the implementation for
> getsockopt was missed which did lead to an error when we tried to
> retrieve the setting for UDP_GRO. This patch adds the missing switch
> case for UDP_GRO
>
> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
> Signed-off-by: Norman Maurer <[email protected]>
> ---
> net/ipv4/udp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

Reviewed-by: David Ahern <[email protected]>

2021-04-01 23:01:01

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 1 Apr 2021 08:59:17 +0200 you wrote:
> From: Norman Maurer <[email protected]>
>
> Support for UDP_GRO was added in the past but the implementation for
> getsockopt was missed which did lead to an error when we tried to
> retrieve the setting for UDP_GRO. This patch adds the missing switch
> case for UDP_GRO
>
> [...]

Here is the summary with links:
- [net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);
https://git.kernel.org/netdev/net/c/98184612aca0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html