2021-04-06 15:21:10

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes

"make versioncheck" shows:

./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not
needed.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
index 5c7dea5..e5bbc0c 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
@@ -30,7 +30,6 @@
#include <linux/regmap.h>
#include <linux/dma-mapping.h>
#include <linux/bcd.h>
-#include <linux/version.h>
#include <linux/usb.h>
#include <linux/usb/hcd.h>

--
1.8.3.1


2021-04-06 15:33:07

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes

On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote:
> "make versioncheck" shows:
>
> ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not
> needed.

Then you need to fix the tool, and always test-build patches before you
send them out, as this is obviously wrong :(

2021-04-21 02:39:18

by Jiapeng Chong

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes

On 2021/4/6 13:26, Greg KH wrote:
> On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote:
>> "make versioncheck" shows:
>>
>> ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not
>> needed.
>
> Then you need to fix the tool, and always test-build patches before you
> send them out, as this is obviously wrong :(
>
Sorry for the noise. We'll do more test-build towards patches next time.