2021-04-07 14:26:44

by Yingjie Wang

Subject: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

From: Yingjie Wang <[email protected]>

In radeon_dp_mst_detect(), We should check whether or not @connector
has been unregistered from userspace. If the connector is unregistered,
we should return disconnected status.

Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)")
Signed-off-by: Yingjie Wang <[email protected]>
---
drivers/gpu/drm/radeon/radeon_dp_mst.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
index 2c32186c4acd..4e4c937c36c6 100644
--- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
+++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
@@ -242,6 +242,9 @@ radeon_dp_mst_detect(struct drm_connector *connector,
to_radeon_connector(connector);
struct radeon_connector *master = radeon_connector->mst_port;

+ if (drm_connector_is_unregistered(connector))
+ return connector_status_disconnected;
+
return drm_dp_mst_detect_port(connector, ctx, &master->mst_mgr,
radeon_connector->port);
}
--
2.7.4

2021-04-08 20:19:55

by Alex Deucher

Subject: Re: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

Applied. Thanks!

Alex

On Wed, Apr 7, 2021 at 2:23 AM <[email protected]> wrote:
>
> From: Yingjie Wang <[email protected]>
>
> In radeon_dp_mst_detect(), We should check whether or not @connector
> has been unregistered from userspace. If the connector is unregistered,
> we should return disconnected status.
>
> Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)")
> Signed-off-by: Yingjie Wang <[email protected]>
> ---
> drivers/gpu/drm/radeon/radeon_dp_mst.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> index 2c32186c4acd..4e4c937c36c6 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> @@ -242,6 +242,9 @@ radeon_dp_mst_detect(struct drm_connector *connector,
> to_radeon_connector(connector);
> struct radeon_connector *master = radeon_connector->mst_port;
>
> + if (drm_connector_is_unregistered(connector))
> + return connector_status_disconnected;
> +
> return drm_dp_mst_detect_port(connector, ctx, &master->mst_mgr,
> radeon_connector->port);
> }
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2021-04-10 01:17:22

by Yingjie Wang

Subject: Re:Re: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

My pleasure!
At 2021-04-09 04:17:36, "Alex Deucher" <[email protected]> wrote:
>Applied. Thanks!
>
>Alex
>
>On Wed, Apr 7, 2021 at 2:23 AM <[email protected]> wrote:
>>
>> From: Yingjie Wang <[email protected]>
>>
>> In radeon_dp_mst_detect(), We should check whether or not @connector
>> has been unregistered from userspace. If the connector is unregistered,
>> we should return disconnected status.
>>
>> Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)")
>> Signed-off-by: Yingjie Wang <[email protected]>
>> ---
>> drivers/gpu/drm/radeon/radeon_dp_mst.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
>> index 2c32186c4acd..4e4c937c36c6 100644
>> --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
>> +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
>> @@ -242,6 +242,9 @@ radeon_dp_mst_detect(struct drm_connector *connector,
>> to_radeon_connector(connector);
>> struct radeon_connector *master = radeon_connector->mst_port;
>>
>> + if (drm_connector_is_unregistered(connector))
>> + return connector_status_disconnected;
>> +
>> return drm_dp_mst_detect_port(connector, ctx, &master->mst_mgr,
>> radeon_connector->port);
>> }
>> --
>> 2.7.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> [email protected]
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel