2021-04-28 10:51:49

by Jiapeng Chong

Subject: [PATCH] nfp: flower: Remove redundant assignment to mask

The value stored to mask in the calculations this patch removes is
not used, so the calculation and the assignment can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/ethernet/netronome/nfp/flower/offload.c:1230:3: warning:
Value stored to 'mask' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ethernet/netronome/nfp/flower/offload.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c
index e95969c..86e734a 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
@@ -1227,7 +1227,6 @@ int nfp_flower_merge_offloaded_flows(struct nfp_app *app,
return -EOPNOTSUPP;
}
ext += size;
- mask += size;
}

if ((priv->flower_ext_feats & NFP_FL_FEATS_VLAN_QINQ)) {
--
1.8.3.1

2021-04-28 20:54:54

by Jakub Kicinski

Subject: Re: [PATCH] nfp: flower: Remove redundant assignment to mask

On Wed, 28 Apr 2021 18:05:30 +0800 Jiapeng Chong wrote:
> The value stored to mask in the calculations this patch removes is
> not used, so the calculation and the assignment can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> drivers/net/ethernet/netronome/nfp/flower/offload.c:1230:3: warning:
> Value stored to 'mask' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Seems cleaner to always move ext and mask, in case some code
is added later in the function and starts accessing mask.