2021-05-11 03:41:01

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] regulator: uniphier: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/regulator/uniphier-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/uniphier-regulator.c b/drivers/regulator/uniphier-regulator.c
index 2e02e26..e75b097 100644
--- a/drivers/regulator/uniphier-regulator.c
+++ b/drivers/regulator/uniphier-regulator.c
@@ -201,6 +201,7 @@ static const struct of_device_id uniphier_regulator_match[] = {
},
{ /* Sentinel */ },
};
+MODULE_DEVICE_TABLE(of, uniphier_regulator_match);

static struct platform_driver uniphier_regulator_driver = {
.probe = uniphier_regulator_probe,
--
2.6.2


2021-05-11 18:24:48

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] regulator: uniphier: Add missing MODULE_DEVICE_TABLE

On Tue, 11 May 2021 11:53:18 +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: uniphier: Add missing MODULE_DEVICE_TABLE
commit: d019f38a1af3c6015cde6a47951a3ec43beeed80

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

2021-05-12 01:44:35

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH -next] regulator: uniphier: Add missing MODULE_DEVICE_TABLE

On Tue, 11 May 2021 11:53:18 +0800
Zou Wei <[email protected]> wrote:

> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Looks good to me.

Acked-by: Masami Hiramatsu <[email protected]>

Thank you!

> ---
> drivers/regulator/uniphier-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/uniphier-regulator.c b/drivers/regulator/uniphier-regulator.c
> index 2e02e26..e75b097 100644
> --- a/drivers/regulator/uniphier-regulator.c
> +++ b/drivers/regulator/uniphier-regulator.c
> @@ -201,6 +201,7 @@ static const struct of_device_id uniphier_regulator_match[] = {
> },
> { /* Sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, uniphier_regulator_match);
>
> static struct platform_driver uniphier_regulator_driver = {
> .probe = uniphier_regulator_probe,
> --
> 2.6.2
>


--
Masami Hiramatsu <[email protected]>