2021-05-25 11:03:43

by Yang Li

Subject: [PATCH] phy: ti: Fix an error code in wiz_probe()

When the code execute this if statement, the value of ret is 0.
However, we can see from the dev_err() log that the value of
ret should be -EINVAL.

Clean up smatch warning:

drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
'ret'

Reported-by: Abaci Robot <[email protected]>
Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
typec-gpio-dir")'
Signed-off-by: Yang Li <[email protected]>
---
drivers/phy/ti/phy-j721e-wiz.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 9eb6d37..126f5b8 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)

if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
+ ret = -EINVAL;
dev_err(dev, "Invalid typec-dir-debounce property\n");
goto err_addr_to_resource;
}
--
1.8.3.1

2021-05-31 08:42:44

by Vinod Koul

Subject: Re: [PATCH] phy: ti: Fix an error code in wiz_probe()

On 25-05-21, 18:50, Yang Li wrote:
> When the code execute this if statement, the value of ret is 0.
> However, we can see from the dev_err() log that the value of
> ret should be -EINVAL.
>
> Clean up smatch warning:
>
> drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
> 'ret'

Single line is fine for this

>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
> typec-gpio-dir")'

Please dont split to two lines for fixes tag

> Signed-off-by: Yang Li <[email protected]>

I have fixed while applying so Applied, thanks

> ---
> drivers/phy/ti/phy-j721e-wiz.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
> index 9eb6d37..126f5b8 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
>
> if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
> wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
> + ret = -EINVAL;
> dev_err(dev, "Invalid typec-dir-debounce property\n");
> goto err_addr_to_resource;
> }
> --
> 1.8.3.1

--
~Vinod