2021-05-27 20:47:53

by Zou Wei

Subject: [PATCH -next] ASoC: imx-rpmsg: fix platform_no_drv_owner.cocci warnings

./sound/soc/fsl/imx-rpmsg.c:140:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
sound/soc/fsl/imx-rpmsg.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c
index 5a9a470..f0cae8c 100644
--- a/sound/soc/fsl/imx-rpmsg.c
+++ b/sound/soc/fsl/imx-rpmsg.c
@@ -137,7 +137,6 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
static struct platform_driver imx_rpmsg_driver = {
.driver = {
.name = "imx-audio-rpmsg",
- .owner = THIS_MODULE,
.pm = &snd_soc_pm_ops,
},
.probe = imx_rpmsg_probe,
--
2.6.2

2021-05-28 17:13:49

by Mark Brown

Subject: Re: [PATCH -next] ASoC: imx-rpmsg: fix platform_no_drv_owner.cocci warnings

From: Mark Brown,,, <[email protected]>

On Thu, 27 May 2021 19:07:32 +0800, Zou Wei wrote:
> ./sound/soc/fsl/imx-rpmsg.c:140:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Applied, thanks!

[1/1] ASoC: imx-rpmsg: fix platform_no_drv_owner.cocci warnings
commit: 47c0d825b926856d86685a48c82f693f56ca3f6f

Best regards,
--
Mark Brown,,, <[email protected]>

2021-05-31 07:16:20

by Shengjiu Wang

Subject: Re: [PATCH -next] ASoC: imx-rpmsg: fix platform_no_drv_owner.cocci warnings

On Thu, May 27, 2021 at 6:48 PM Zou Wei <[email protected]> wrote:
>
> ./sound/soc/fsl/imx-rpmsg.c:140:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Acked-by: Shengjiu Wang <[email protected]>

> ---
> sound/soc/fsl/imx-rpmsg.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c
> index 5a9a470..f0cae8c 100644
> --- a/sound/soc/fsl/imx-rpmsg.c
> +++ b/sound/soc/fsl/imx-rpmsg.c
> @@ -137,7 +137,6 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
> static struct platform_driver imx_rpmsg_driver = {
> .driver = {
> .name = "imx-audio-rpmsg",
> - .owner = THIS_MODULE,
> .pm = &snd_soc_pm_ops,
> },
> .probe = imx_rpmsg_probe,
> --
> 2.6.2
>