2021-07-14 13:26:07

by Shunyong Yang

Subject: [PATCH v2] tools: PCI: Zero-initialize param

The values in param may be random if they are not initialized, which
may cause use_dma flag set even when "-d" option is not provided
in command line. Initializing all members to 0 to solve this.

Signed-off-by: Shunyong Yang <[email protected]>
---
v2: Change {0} to {} as Leon Romanovsky's comment.
---
tools/pci/pcitest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 0a1344c45213..441b54234635 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -40,7 +40,7 @@ struct pci_test {

static int run_test(struct pci_test *test)
{
- struct pci_endpoint_test_xfer_param param;
+ struct pci_endpoint_test_xfer_param param = {};
int ret = -EINVAL;
int fd;

--
2.25.1

2021-07-14 13:35:12

by Kishon Vijay Abraham I

Subject: Re: [PATCH v2] tools: PCI: Zero-initialize param

On 14/07/21 6:53 pm, Shunyong Yang wrote:
> The values in param may be random if they are not initialized, which
> may cause use_dma flag set even when "-d" option is not provided
> in command line. Initializing all members to 0 to solve this.
>
> Signed-off-by: Shunyong Yang <[email protected]>

Thanks for the fix.

Acked-by: Kishon Vijay Abraham I <[email protected]>


> ---
> v2: Change {0} to {} as Leon Romanovsky's comment.
> ---
> tools/pci/pcitest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index 0a1344c45213..441b54234635 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -40,7 +40,7 @@ struct pci_test {
>
> static int run_test(struct pci_test *test)
> {
> - struct pci_endpoint_test_xfer_param param;
> + struct pci_endpoint_test_xfer_param param = {};
> int ret = -EINVAL;
> int fd;
>
>

2021-08-03 11:53:18

by Shunyong Yang

Subject: Re: [PATCH v2] tools: PCI: Zero-initialize param

Hi, Bjorn,

   Would you please help to review and put this tiny fix (for
tools/pci/pcitest.c) in your merge queue? Kishon has acked.

Thanks.

Shunyong

On 2021/7/14 21:32, Kishon Vijay Abraham I wrote:
>
> On 14/07/21 6:53 pm, Shunyong Yang wrote:
>> The values in param may be random if they are not initialized, which
>> may cause use_dma flag set even when "-d" option is not provided
>> in command line. Initializing all members to 0 to solve this.
>>
>> Signed-off-by: Shunyong Yang <[email protected]>
> Thanks for the fix.
>
> Acked-by: Kishon Vijay Abraham I <[email protected]>
>
>
>> ---
>> v2: Change {0} to {} as Leon Romanovsky's comment.
>> ---
>> tools/pci/pcitest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
>> index 0a1344c45213..441b54234635 100644
>> --- a/tools/pci/pcitest.c
>> +++ b/tools/pci/pcitest.c
>> @@ -40,7 +40,7 @@ struct pci_test {
>>
>> static int run_test(struct pci_test *test)
>> {
>> - struct pci_endpoint_test_xfer_param param;
>> + struct pci_endpoint_test_xfer_param param = {};
>> int ret = -EINVAL;
>> int fd;
>>
>>

2021-08-05 12:57:53

by Lorenzo Pieralisi

Subject: Re: [PATCH v2] tools: PCI: Zero-initialize param

On Wed, 14 Jul 2021 21:23:31 +0800, Shunyong Yang wrote:
> The values in param may be random if they are not initialized, which
> may cause use_dma flag set even when "-d" option is not provided
> in command line. Initializing all members to 0 to solve this.

Applied to pci/tools, thanks!

[1/1] tools: PCI: Zero-initialize param
https://git.kernel.org/lpieralisi/pci/c/224d8031e4

Thanks,
Lorenzo