2021-09-03 07:53:20

by Yang Li

Subject: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer

sizeof() when applied to a pointer typed expression gives the size of
the pointer.

Clean up coccicheck warning:
./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
pointer

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
arch/um/drivers/virt-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
index c080666..156af2f 100644
--- a/arch/um/drivers/virt-pci.c
+++ b/arch/um/drivers/virt-pci.c
@@ -189,7 +189,7 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
buf = get_cpu_var(um_pci_msg_bufs);
data = buf->data;

- memset(data, 0xff, sizeof(data));
+ memset(data, 0xff, sizeof(*data));

switch (size) {
case 1:
--
1.8.3.1

2021-09-03 08:22:25

by Johannes Berg

Subject: Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer

On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
> sizeof() when applied to a pointer typed expression gives the size of
> the pointer.
>
> Clean up coccicheck warning:
> ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
> pointer
>

> - memset(data, 0xff, sizeof(data));
> + memset(data, 0xff, sizeof(*data));

Oops. I guess I only tested on 64-bit where this is the same, and in
fact on 32-bit it also wouldn't matter since you can't even do 64-bit
reads there :)

A Fixes: tag would be nice, but otherwise

Reviewed-by: Johannes Berg <[email protected]>

johannes