2021-09-06 11:18:08

by Jiapeng Chong

Subject: [PATCH] trap: Fix warning comparing pointer to 0

From: chongjiapeng <[email protected]>

Fix the following coccicheck warning:

./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: chongjiapeng <[email protected]>
---
arch/hexagon/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
index edfc35d..3b6e0de 100644
--- a/arch/hexagon/kernel/traps.c
+++ b/arch/hexagon/kernel/traps.c
@@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, unsigned long *fp,
}

/* Attempt to continue past exception. */
- if (0 == newfp) {
+ if (!newfp) {
struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
+ 8);

--
1.8.3.1

2021-09-07 02:30:34

by Brian Cain

Subject: RE: [PATCH] trap: Fix warning comparing pointer to 0

> -----Original Message-----
> From: Jiapeng Chong <[email protected]>
> Sent: Monday, September 6, 2021 4:33 AM
> To: [email protected]
> Cc: [email protected]; [email protected];
> chongjiapeng <[email protected]>
> Subject: [PATCH] trap: Fix warning comparing pointer to 0
>
> From: chongjiapeng <[email protected]>
>
> Fix the following coccicheck warning:
>
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: chongjiapeng <[email protected]>
> ---
> arch/hexagon/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index edfc35d..3b6e0de 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> }
>
> /* Attempt to continue past exception. */
> - if (0 == newfp) {
> + if (!newfp) {
> struct pt_regs *regs = (struct pt_regs *) (((void
*)fp)
> + 8);
>

Reviewed-by: Brian Cain <[email protected]>