2021-10-18 03:49:54

by Jiabing Wan

Subject: [PATCH] net: mscc: ocelot: Add of_node_put() before goto

Fix following coccicheck warning:
./drivers/net/ethernet/mscc/ocelot_vsc7514.c:946:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before goto.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/net/ethernet/mscc/ocelot_vsc7514.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
index 5d01993f6be0..38103b0255b0 100644
--- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c
+++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
@@ -969,6 +969,7 @@ static int mscc_ocelot_init_ports(struct platform_device *pdev,
target = ocelot_regmap_init(ocelot, res);
if (IS_ERR(target)) {
err = PTR_ERR(target);
+ of_node_put(portnp);
goto out_teardown;
}

--
2.20.1

2021-10-18 12:51:22

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: mscc: ocelot: Add of_node_put() before goto

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Sun, 17 Oct 2021 21:32:32 -0400 you wrote:
> Fix following coccicheck warning:
> ./drivers/net/ethernet/mscc/ocelot_vsc7514.c:946:1-33: WARNING: Function
> for_each_available_child_of_node should have of_node_put() before goto.
>
> Early exits from for_each_available_child_of_node should decrement the
> node reference counter.
>
> [...]

Here is the summary with links:
- net: mscc: ocelot: Add of_node_put() before goto
https://git.kernel.org/netdev/net/c/d1a7b9e46965

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html